Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Python][CI] Add upper bound on pytest version #39827

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Jan 29, 2024

Rationale for this change

The PyArrow test suite relies on the pytest-lazy-fixture plugin, which breaks on pytest 8.0.0: TvoroG/pytest-lazy-fixture#65

What changes are included in this PR?

Avoid installing pytest 8 on CI builds, by putting an upper bound on the pytest version.

Are these changes tested?

Yes, by construction.

Are there any user-facing changes?

No.

The PyArrow test suite relies on the pytest-lazy-fixture plugin, which breaks on pytest 8.0.0:
TvoroG/pytest-lazy-fixture#65
@pitrou
Copy link
Member Author

pitrou commented Jan 29, 2024

@github-actions crossbow submit -g python -g wheel

Copy link

Revision: c91af6a

Submitted crossbow builds: ursacomputing/crossbow @ actions-13f2836a4e

Task Status
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-cython2 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest GitHub Actions
test-conda-python-3.10-pandas-nightly GitHub Actions
test-conda-python-3.10-spark-v3.5.0 GitHub Actions
test-conda-python-3.10-substrait GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-upstream_devel GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.8 GitHub Actions
test-conda-python-3.8-pandas-1.0 GitHub Actions
test-conda-python-3.8-spark-v3.5.0 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-latest GitHub Actions
test-cuda-python GitHub Actions
test-debian-11-python-3 Azure
test-fedora-38-python-3 Azure
test-ubuntu-20.04-python-3 Azure
test-ubuntu-22.04-python-3 GitHub Actions
wheel-macos-big-sur-cp310-arm64 GitHub Actions
wheel-macos-big-sur-cp311-arm64 GitHub Actions
wheel-macos-big-sur-cp312-arm64 GitHub Actions
wheel-macos-big-sur-cp38-arm64 GitHub Actions
wheel-macos-big-sur-cp39-arm64 GitHub Actions
wheel-macos-catalina-cp310-amd64 GitHub Actions
wheel-macos-catalina-cp311-amd64 GitHub Actions
wheel-macos-catalina-cp312-amd64 GitHub Actions
wheel-macos-catalina-cp38-amd64 GitHub Actions
wheel-macos-catalina-cp39-amd64 GitHub Actions
wheel-manylinux-2-28-cp310-amd64 GitHub Actions
wheel-manylinux-2-28-cp310-arm64 GitHub Actions
wheel-manylinux-2-28-cp311-amd64 GitHub Actions
wheel-manylinux-2-28-cp311-arm64 GitHub Actions
wheel-manylinux-2-28-cp312-amd64 GitHub Actions
wheel-manylinux-2-28-cp312-arm64 GitHub Actions
wheel-manylinux-2-28-cp38-amd64 GitHub Actions
wheel-manylinux-2-28-cp38-arm64 GitHub Actions
wheel-manylinux-2-28-cp39-amd64 GitHub Actions
wheel-manylinux-2-28-cp39-arm64 GitHub Actions
wheel-manylinux-2014-cp310-amd64 GitHub Actions
wheel-manylinux-2014-cp310-arm64 GitHub Actions
wheel-manylinux-2014-cp311-amd64 GitHub Actions
wheel-manylinux-2014-cp311-arm64 GitHub Actions
wheel-manylinux-2014-cp312-amd64 GitHub Actions
wheel-manylinux-2014-cp312-arm64 GitHub Actions
wheel-manylinux-2014-cp38-amd64 GitHub Actions
wheel-manylinux-2014-cp38-arm64 GitHub Actions
wheel-manylinux-2014-cp39-amd64 GitHub Actions
wheel-manylinux-2014-cp39-arm64 GitHub Actions
wheel-windows-cp310-amd64 GitHub Actions
wheel-windows-cp311-amd64 GitHub Actions
wheel-windows-cp312-amd64 GitHub Actions
wheel-windows-cp38-amd64 GitHub Actions
wheel-windows-cp39-amd64 GitHub Actions

@pitrou
Copy link
Member Author

pitrou commented Jan 29, 2024

I'll merge this so as to improve the state of our CI.

@pitrou pitrou merged commit 87dd4c4 into apache:main Jan 29, 2024
11 of 12 checks passed
@pitrou pitrou removed the awaiting review Awaiting review label Jan 29, 2024
@pitrou pitrou deleted the pytest-pin branch January 29, 2024 16:41
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 87dd4c4.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

@raulcd raulcd added this to the 15.0.1 milestone Feb 14, 2024
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
### Rationale for this change

The PyArrow test suite relies on the pytest-lazy-fixture plugin, which breaks on pytest 8.0.0: TvoroG/pytest-lazy-fixture#65

### What changes are included in this PR?

Avoid installing pytest 8 on CI builds, by putting an upper bound on the pytest version.

### Are these changes tested?

Yes, by construction.

### Are there any user-facing changes?

No.

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
raulcd pushed a commit that referenced this pull request Feb 20, 2024
### Rationale for this change

The PyArrow test suite relies on the pytest-lazy-fixture plugin, which breaks on pytest 8.0.0: TvoroG/pytest-lazy-fixture#65

### What changes are included in this PR?

Avoid installing pytest 8 on CI builds, by putting an upper bound on the pytest version.

### Are these changes tested?

Yes, by construction.

### Are there any user-facing changes?

No.

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Feb 28, 2024
### Rationale for this change

The PyArrow test suite relies on the pytest-lazy-fixture plugin, which breaks on pytest 8.0.0: TvoroG/pytest-lazy-fixture#65

### What changes are included in this PR?

Avoid installing pytest 8 on CI builds, by putting an upper bound on the pytest version.

### Are these changes tested?

Yes, by construction.

### Are there any user-facing changes?

No.

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Mar 8, 2024
### Rationale for this change

The PyArrow test suite relies on the pytest-lazy-fixture plugin, which breaks on pytest 8.0.0: TvoroG/pytest-lazy-fixture#65

### What changes are included in this PR?

Avoid installing pytest 8 on CI builds, by putting an upper bound on the pytest version.

### Are these changes tested?

Yes, by construction.

### Are there any user-facing changes?

No.

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants