Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Remove Scalar legacy cast from Cython test #40023

Closed
llama90 opened this issue Feb 10, 2024 · 1 comment · Fixed by #40116
Closed

[Python] Remove Scalar legacy cast from Cython test #40023

llama90 opened this issue Feb 10, 2024 · 1 comment · Fixed by #40116

Comments

@llama90
Copy link
Contributor

llama90 commented Feb 10, 2024

Describe the enhancement requested

This is a sub-issue of the issue mentioned below.

To resolve the main issue, we need to replace it with Cast or remove the legacy CastTo from Cython.

To solve the main issue better, this should come before the main issue.

error message in the python workflow
----------------------------- Captured stderr call -----------------------------
pyarrow_cython_example.cpp:8782:46: error: no member named 'CastTo' in 'arrow::Scalar'
  __pyx_v_c_result = __pyx_v_c_scalar.get()->CastTo(__pyx_v_c_type);
                     ~~~~~~~~~~~~~~~~~~~~~~  ^
1 error generated.
error: command '/usr/bin/clang' failed with exit code 1

Component(s)

Python

@llama90
Copy link
Contributor Author

llama90 commented Feb 10, 2024

take

AlenkaF pushed a commit that referenced this issue Mar 11, 2024
### Rationale for this change

Remove legacy code

### What changes are included in this PR?

* Replace the legacy scalar CastTo implementation for Python.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.

* Closes: #40023

Authored-by: Hyunseok Seo <hsseo0501@gmail.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
@AlenkaF AlenkaF added this to the 16.0.0 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants