Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-40023: [Python] Use Cast() instead of CastTo #40116

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

llama90
Copy link
Contributor

@llama90 llama90 commented Feb 18, 2024

Rationale for this change

Remove legacy code

What changes are included in this PR?

  • Replace the legacy scalar CastTo implementation for Python.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@llama90
Copy link
Contributor Author

llama90 commented Feb 24, 2024

@AlenkaF Hello.

If I would like to get this part reviewed, who should I ask? Thank you.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Feb 27, 2024
@AlenkaF
Copy link
Member

AlenkaF commented Feb 27, 2024

Added a small comment, otherwise LGTM 👍
I think the CI should be green if you rebase.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Feb 27, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Feb 28, 2024
@llama90
Copy link
Contributor Author

llama90 commented Feb 28, 2024

BTW, It didn't work for me with 3.10, so when I configured it to 3.8, it worked.

It is right?

$ conda create -y -n pyarrow-dev -c conda-forge \
--file arrow/ci/conda_env_unix.txt \
--file arrow/ci/conda_env_cpp.txt \
--file arrow/ci/conda_env_python.txt \
--file arrow/ci/conda_env_gandiva.txt \
compilers \
python=3.10 \
pandas

@llama90
Copy link
Contributor Author

llama90 commented Mar 4, 2024

@AlenkaF @jorisvandenbossche

Hello.
Could I request a review to proceed with additional tasks related to this?
Thank you.

Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@llama90
Copy link
Contributor Author

llama90 commented Mar 8, 2024

@AlenkaF Hello.

If there are no problems, can you merge it?

@AlenkaF
Copy link
Member

AlenkaF commented Mar 8, 2024

@github-actions crossbow submit -g python

Copy link

github-actions bot commented Mar 8, 2024

Revision: 159b7eb

Submitted crossbow builds: ursacomputing/crossbow @ actions-7a0a16d5b4

Task Status
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-cython2 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest GitHub Actions
test-conda-python-3.10-pandas-nightly GitHub Actions
test-conda-python-3.10-spark-v3.5.0 GitHub Actions
test-conda-python-3.10-substrait GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-upstream_devel GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.8 GitHub Actions
test-conda-python-3.8-pandas-1.0 GitHub Actions
test-conda-python-3.8-spark-v3.5.0 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-latest GitHub Actions
test-cuda-python GitHub Actions
test-debian-11-python-3-amd64 Azure
test-debian-11-python-3-i386 GitHub Actions
test-fedora-39-python-3 Azure
test-ubuntu-20.04-python-3 Azure
test-ubuntu-22.04-python-3 GitHub Actions

@AlenkaF
Copy link
Member

AlenkaF commented Mar 8, 2024

@llama90 could you rebase? I think the failures should be gone then =)

@llama90
Copy link
Contributor Author

llama90 commented Mar 8, 2024

Oh! I rebased it.

@llama90 llama90 requested a review from AlenkaF March 8, 2024 12:16
@AlenkaF
Copy link
Member

AlenkaF commented Mar 8, 2024

@github-actions crossbow submit -g python

Copy link

github-actions bot commented Mar 8, 2024

Revision: 40b0711

Submitted crossbow builds: ursacomputing/crossbow @ actions-f68cc7f299

Task Status
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-cython2 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest GitHub Actions
test-conda-python-3.10-pandas-nightly GitHub Actions
test-conda-python-3.10-spark-v3.5.0 GitHub Actions
test-conda-python-3.10-substrait GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-upstream_devel GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.8 GitHub Actions
test-conda-python-3.8-pandas-1.0 GitHub Actions
test-conda-python-3.8-spark-v3.5.0 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-latest GitHub Actions
test-cuda-python GitHub Actions
test-debian-11-python-3-amd64 Azure
test-debian-11-python-3-i386 GitHub Actions
test-fedora-39-python-3 Azure
test-ubuntu-20.04-python-3 Azure
test-ubuntu-22.04-python-3 GitHub Actions

Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing builds are not connected and have open issues:

Thank you for you contributions @llama90 !

@AlenkaF AlenkaF merged commit b171b26 into apache:main Mar 11, 2024
11 of 12 checks passed
@AlenkaF AlenkaF removed the awaiting change review Awaiting change review label Mar 11, 2024
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Mar 11, 2024
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit b171b26.

There was 1 benchmark result with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python] Remove Scalar legacy cast from Cython test
3 participants