-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-40023: [Python] Use Cast() instead of CastTo #40116
Conversation
@AlenkaF Hello. If I would like to get this part reviewed, who should I ask? Thank you. |
Added a small comment, otherwise LGTM 👍 |
BTW, It didn't work for me with 3.10, so when I configured it to 3.8, it worked. It is right? arrow/docs/source/developers/python.rst Lines 212 to 219 in d6b9051
|
Hello. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@AlenkaF Hello. If there are no problems, can you merge it? |
@github-actions crossbow submit -g python |
Revision: 159b7eb Submitted crossbow builds: ursacomputing/crossbow @ actions-7a0a16d5b4 |
@llama90 could you rebase? I think the failures should be gone then =) |
Oh! I rebased it. |
@github-actions crossbow submit -g python |
Revision: 40b0711 Submitted crossbow builds: ursacomputing/crossbow @ actions-f68cc7f299 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failing builds are not connected and have open issues:
- pandas latest: [Python] NumPy 2 ABI changes (elsize) #40376
- AppVeyor [Python][CI] Failing test_dateutil_tzinfo_to_string due to new release of python-dateutil #40337
Thank you for you contributions @llama90 !
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit b171b26. There was 1 benchmark result with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Remove legacy code
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
No.