Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][S3] Improve narrative tests #40151

Closed
pitrou opened this issue Feb 20, 2024 · 0 comments · Fixed by #40144
Closed

[C++][S3] Improve narrative tests #40151

pitrou opened this issue Feb 20, 2024 · 0 comments · Fixed by #40144
Assignees
@pitrou
Labels
Component: C++ Type: enhancement
Milestone
16.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Feb 20, 2024

Describe the enhancement requested

arrow-s3fs-narrative-test allows manual testing of the S3 filesystem implementation against an actual S3 backend such as AWS.

When testing against a non-AWS endpoint such as LocalStack, additional functionality may be required:

  • the ability to set the endpoint address
  • the ability to create the test bucket

Component(s)

C++
@pitrou pitrou self-assigned this Feb 20, 2024
@github-actions github-actions bot mentioned this issue Feb 20, 2024
Merged
pitrou added a commit that referenced this issue Feb 20, 2024
@pitrou
GH-40151: [C++] Make S3 narrative test more flexible (#40144)
4dc3d04 
`arrow-s3fs-narrative-test` allows manual testing of the S3 filesystem implementation against an actual S3 backend such as AWS.

This PR allows customizing the endpoint address, and adds a command to create a bucket for testing.

Validated with the LocalStack S3 server.

* Closes: #40151

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 16.0.0 milestone Feb 20, 2024
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@pitrou @zanmato1984
apacheGH-40151: [C++] Make S3 narrative test more flexible (apache#40144
ab57869 
)

`arrow-s3fs-narrative-test` allows manual testing of the S3 filesystem implementation against an actual S3 backend such as AWS.

This PR allows customizing the endpoint address, and adds a command to create a bucket for testing.

Validated with the LocalStack S3 server.

* Closes: apache#40151

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@pitrou @thisisnic
apacheGH-40151: [C++] Make S3 narrative test more flexible (apache#40144
199001e 
)

`arrow-s3fs-narrative-test` allows manual testing of the S3 filesystem implementation against an actual S3 backend such as AWS.

This PR allows customizing the endpoint address, and adds a command to create a bucket for testing.

Validated with the LocalStack S3 server.

* Closes: apache#40151

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

Successfully merging a pull request may close this issue.

GH-40151: [C++] Make S3 narrative test more flexible pitrou/arrow
1 participant
@pitrou