Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] FixedSizeListType is not considered as a nested type #40171

Closed
hussein-awala opened this issue Feb 21, 2024 · 0 comments · Fixed by #40172
Closed

[Python] FixedSizeListType is not considered as a nested type #40171

hussein-awala opened this issue Feb 21, 2024 · 0 comments · Fixed by #40172
Assignees
@hussein-awala
Labels
Component: Python Type: bug
Milestone
16.0.0

Comments

@hussein-awala
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

>>> import pyarrow as pa
>>> pa.list_(pa.int32())
ListType(list<item: int32>)
>>> pa.list_(pa.int32(), 3)
FixedSizeListType(fixed_size_list<item: int32>[3])
>>> pa.types.is_nested(pa.list_(pa.int32()))
True
>>> pa.types.is_nested(pa.list_(pa.int32(), 3))
False

Component(s)

Python
hussein-awala added a commit to hussein-awala/arrow that referenced this issue Feb 21, 2024
@hussein-awala
apacheGH-40171: [Python] Add Type_FIXED_SIZE_LIST to _NESTED_TYPES set
25f0ef8
@github-actions github-actions bot mentioned this issue Feb 21, 2024
Merged
jorisvandenbossche pushed a commit that referenced this issue Feb 27, 2024
@hussein-awala
GH-40171: [Python] Add Type_FIXED_SIZE_LIST to _NESTED_TYPES set (#40172
3f7b288 
)

### Rationale for this change

### What changes are included in this PR?

This PR fixes a minor bug in `types.is_nested` which doesn't consider the `FIXED_SIZE_LIST` type as nested type.

### Are these changes tested?

### Are there any user-facing changes?

* Closes: #40171

Authored-by: hussein-awala <hussein@awala.fr>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jorisvandenbossche jorisvandenbossche added this to the 16.0.0 milestone Feb 27, 2024
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@hussein-awala @zanmato1984
apacheGH-40171: [Python] Add Type_FIXED_SIZE_LIST to _NESTED_TYPES set (
a801fcc 
apache#40172)

### Rationale for this change

### What changes are included in this PR?

This PR fixes a minor bug in `types.is_nested` which doesn't consider the `FIXED_SIZE_LIST` type as nested type.

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#40171

Authored-by: hussein-awala <hussein@awala.fr>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@hussein-awala @thisisnic
apacheGH-40171: [Python] Add Type_FIXED_SIZE_LIST to _NESTED_TYPES set (
95acea4 
apache#40172)

### Rationale for this change

### What changes are included in this PR?

This PR fixes a minor bug in `types.is_nested` which doesn't consider the `FIXED_SIZE_LIST` type as nested type.

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#40171

Authored-by: hussein-awala <hussein@awala.fr>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hussein-awala hussein-awala

Labels
Component: Python Type: bug
Projects
None yet
Milestone
16.0.0
Development

Successfully merging a pull request may close this issue.

GH-40171: [Python] Add Type_FIXED_SIZE_LIST to _NESTED_TYPES set hussein-awala/arrow
2 participants
@jorisvandenbossche @hussein-awala