-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-40171: [Python] Add Type_FIXED_SIZE_LIST to _NESTED_TYPES set #40172
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks like an oversight in is_nested
indeed
@danepitkin too late for this PR, but that reminds me we should also add the list view types here (maybe you can do that in one of the open/future PRs you are still doing for list view) |
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 3f7b288. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
apache#40172) ### Rationale for this change ### What changes are included in this PR? This PR fixes a minor bug in `types.is_nested` which doesn't consider the `FIXED_SIZE_LIST` type as nested type. ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#40171 Authored-by: hussein-awala <hussein@awala.fr> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
apache#40172) ### Rationale for this change ### What changes are included in this PR? This PR fixes a minor bug in `types.is_nested` which doesn't consider the `FIXED_SIZE_LIST` type as nested type. ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#40171 Authored-by: hussein-awala <hussein@awala.fr> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Rationale for this change
What changes are included in this PR?
This PR fixes a minor bug in
types.is_nested
which doesn't consider theFIXED_SIZE_LIST
type as nested type.Are these changes tested?
Are there any user-facing changes?