GH-40171: [Python] Add Type_FIXED_SIZE_LIST to _NESTED_TYPES set #40172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jorisvandenbossche
approved these changes
Feb 27, 2024
|
@danepitkin too late for this PR, but that reminds me we should also add the list view types here (maybe you can do that in one of the open/future PRs you are still doing for list view) |
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 3f7b288. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
apache#40172) ### Rationale for this change ### What changes are included in this PR? This PR fixes a minor bug in `types.is_nested` which doesn't consider the `FIXED_SIZE_LIST` type as nested type. ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#40171 Authored-by: hussein-awala <hussein@awala.fr> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
apache#40172) ### Rationale for this change ### What changes are included in this PR? This PR fixes a minor bug in `types.is_nested` which doesn't consider the `FIXED_SIZE_LIST` type as nested type. ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#40171 Authored-by: hussein-awala <hussein@awala.fr> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
This PR fixes a minor bug in
types.is_nestedwhich doesn't consider theFIXED_SIZE_LISTtype as nested type.Are these changes tested?
Are there any user-facing changes?