-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R] create_package_with_all_dependencies
leaves files unexecutable
#40227
Comments
Would you be interested in submitting a pull request with this change? |
I'd be happy to! |
thisisnic
pushed a commit
that referenced
this issue
Mar 6, 2024
…endencies` (#40232) ### What changes are included in this PR? - Set the `utils::tar` `extra_flags` argument to `NULL` (default `""`). This benefits from logic baked in (also used by `R CMD BUILD`) that checks the mode of `configure` and `cleanup` files and sets them to be executable if they are not already. ### Are these changes tested? No. I didn't see any existing tests for this function (which perhaps is not a valid reason). ### Are there any user-facing changes? No. Although if `configure` and/or `cleanup` are not executable, that will be corrected with a user-facing `warning`. * GitHub Issue: #40227 edit: revised the description based on the new approach in 40e8add. Authored-by: Paul Donnelly <donnelpa@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
Issue resolved by pull request 40232 |
mapleFU
pushed a commit
to mapleFU/arrow
that referenced
this issue
Mar 7, 2024
…ll_dependencies` (apache#40232) ### What changes are included in this PR? - Set the `utils::tar` `extra_flags` argument to `NULL` (default `""`). This benefits from logic baked in (also used by `R CMD BUILD`) that checks the mode of `configure` and `cleanup` files and sets them to be executable if they are not already. ### Are these changes tested? No. I didn't see any existing tests for this function (which perhaps is not a valid reason). ### Are there any user-facing changes? No. Although if `configure` and/or `cleanup` are not executable, that will be corrected with a user-facing `warning`. * GitHub Issue: apache#40227 edit: revised the description based on the new approach in 40e8add. Authored-by: Paul Donnelly <donnelpa@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this issue
Mar 8, 2024
…ll_dependencies` (apache#40232) ### What changes are included in this PR? - Set the `utils::tar` `extra_flags` argument to `NULL` (default `""`). This benefits from logic baked in (also used by `R CMD BUILD`) that checks the mode of `configure` and `cleanup` files and sets them to be executable if they are not already. ### Are these changes tested? No. I didn't see any existing tests for this function (which perhaps is not a valid reason). ### Are there any user-facing changes? No. Although if `configure` and/or `cleanup` are not executable, that will be corrected with a user-facing `warning`. * GitHub Issue: apache#40227 edit: revised the description based on the new approach in 40e8add. Authored-by: Paul Donnelly <donnelpa@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
I used
create_package_with_all_dependencies
on a Windows machine and then copied the tarball to a Linux machine. When I went to install the tarball, I received this error:Reviewing the code, we see the files are simply
tar
'd back after downloading the dependencies into the untarred package:arrow/r/R/install-arrow.R
Line 254 in b8fff04
I found that if I replace the above line with a
pkgbuild::build
call, the missing executable bits are automatically fixed:After making this change, the install on the Windows and Linux machines worked great. Perhaps there could be a step that sets these as executable manually, or replace
tar
withbuild
, which includes other checks to ensure a valid package build.BTW thanks for making this script, it's incredibly useful!
Component(s)
R
The text was updated successfully, but these errors were encountered: