Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Mark ListView as a nested type #40266

Closed
danepitkin opened this issue Feb 27, 2024 · 1 comment
Closed

[Python] Mark ListView as a nested type #40266

danepitkin opened this issue Feb 27, 2024 · 1 comment
Assignees
@danepitkin
Labels
Component: Python Type: bug
Milestone
16.0.0

Comments

@danepitkin
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

ListView is a nested type and should be marked as such.

>>> import pyarrow as pa
>>> pa.types.is_nested(pa.list_view(pa.int32()))
False

Component(s)

Python
@github-actions github-actions bot mentioned this issue Feb 27, 2024
Merged
jorisvandenbossche pushed a commit that referenced this issue Feb 28, 2024
@danepitkin
GH-40266: [Python] Mark ListView as a nested type (#40265)
d519a4c 
### Rationale for this change

ListView types are nested, so `is_nested()` should return True.

### What changes are included in this PR?

* `pa.types.is_nested(pa.list_view(<type>))` returns True

### Are these changes tested?

Yes, unit tested.

### Are there any user-facing changes?

Yes.
* GitHub Issue: #40266

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jorisvandenbossche
Copy link
Member

Issue resolved by pull request 40265
#40265

@jorisvandenbossche jorisvandenbossche added this to the 16.0.0 milestone Feb 28, 2024
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@danepitkin @zanmato1984
apacheGH-40266: [Python] Mark ListView as a nested type (apache#40265)
f52ed26 
### Rationale for this change

ListView types are nested, so `is_nested()` should return True.

### What changes are included in this PR?

* `pa.types.is_nested(pa.list_view(<type>))` returns True

### Are these changes tested?

Yes, unit tested.

### Are there any user-facing changes?

Yes.
* GitHub Issue: apache#40266

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@danepitkin @thisisnic
apacheGH-40266: [Python] Mark ListView as a nested type (apache#40265)
4134cfc 
### Rationale for this change

ListView types are nested, so `is_nested()` should return True.

### What changes are included in this PR?

* `pa.types.is_nested(pa.list_view(<type>))` returns True

### Are these changes tested?

Yes, unit tested.

### Are there any user-facing changes?

Yes.
* GitHub Issue: apache#40266

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danepitkin danepitkin

Labels
Component: Python Type: bug
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
2 participants
@jorisvandenbossche @danepitkin