-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++][Python] glog 0.7 fix breaks downstream packages #40274
Comments
This was referenced Feb 28, 2024
Full build logs:
|
kou
added a commit
to kou/arrow
that referenced
this issue
Feb 28, 2024
kou
added a commit
that referenced
this issue
Feb 29, 2024
### Rationale for this change glog uses "glog" not "GLOG" as CMake package name. So we should follow it. ### What changes are included in this PR? Use "glogAlt" for our glog CMake module name to distinct upstream's CMake package name. ### Are these changes tested? No. We don't have CI with glog 0.7 yet. ### Are there any user-facing changes? Yes. * GitHub Issue: #40274 Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Issue resolved by pull request 40275 |
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this issue
Mar 8, 2024
### Rationale for this change glog uses "glog" not "GLOG" as CMake package name. So we should follow it. ### What changes are included in this PR? Use "glogAlt" for our glog CMake module name to distinct upstream's CMake package name. ### Are these changes tested? No. We don't have CI with glog 0.7 yet. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#40274 Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
After applying #40230 to the cpp library and building with glog 0.7. Anything building with ArrowConfig.cmake now fails. For example a pyarrow wheel build:
This was not the case before.
The build fails because ArrowConfig.cmake requires but cannot find uppercase GLOG.
Originally posted by @bnavigator in #40230 (comment)
Component(s)
C++, Python
The text was updated successfully, but these errors were encountered: