Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Python] glog 0.7 fix breaks downstream packages #40274

Closed
bnavigator opened this issue Feb 28, 2024 · 2 comments
Closed

[C++][Python] glog 0.7 fix breaks downstream packages #40274

bnavigator opened this issue Feb 28, 2024 · 2 comments
Assignees
@kou
Labels
Component: C++ Component: Python
Milestone
16.0.0

Comments

@bnavigator
Copy link

bnavigator commented Feb 28, 2024 •
edited

Describe the bug, including details regarding any error messages, version, and platform.

After applying #40230 to the cpp library and building with glog 0.7. Anything building with ArrowConfig.cmake now fails. For example a pyarrow wheel build:

[   31s]   CMake Error at CMakeLists.txt:268 (find_package):
[   31s]     Found package configuration file:
[   31s] 
[   31s]       /usr/lib64/cmake/Arrow/ArrowConfig.cmake
[   31s] 
[   31s]     but it set Arrow_FOUND to FALSE so package "Arrow" is considered to be NOT
[   31s]     FOUND.  Reason given by package:
[   31s] 
[   31s]     Arrow could not be found because dependency GLOG could not be found.
[   31s] 
[   31s] 
[   31s] 
[   31s]   -- Configuring incomplete, errors occurred!

This was not the case before.

The build fails because ArrowConfig.cmake requires but cannot find uppercase GLOG.

Originally posted by @bnavigator in #40230 (comment)

Component(s)

C++, Python
This was referenced Feb 28, 2024
Merged
Closed
@bnavigator
Copy link
Author

Full build logs:

@bnavigator bnavigator changed the title glog 0.7 fix breaks downstream packages [C++][Python] glog 0.7 fix breaks downstream packages Feb 28, 2024
kou added a commit to kou/arrow that referenced this issue Feb 28, 2024
@kou
apacheGH-40274: [C++] Add support for system glog 0.7
32c4494
@github-actions github-actions bot mentioned this issue Feb 28, 2024
Merged
kou added a commit that referenced this issue Feb 29, 2024
@kou
GH-40274: [C++] Add support for system glog 0.7 (#40275)
7e691d5 
### Rationale for this change

glog uses "glog" not "GLOG" as CMake package name. So we should follow it.

### What changes are included in this PR?

Use "glogAlt" for our glog CMake module name to distinct upstream's CMake package name. 

### Are these changes tested?

No. We don't have CI with glog 0.7 yet.

### Are there any user-facing changes?

Yes.
* GitHub Issue: #40274

Lead-authored-by: Sutou Kouhei <kou@clear-code.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou
Copy link
Member

kou commented Feb 29, 2024

Issue resolved by pull request 40275
#40275

@kou kou added this to the 16.0.0 milestone Feb 29, 2024
@kou kou closed this as completed Feb 29, 2024
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@kou @thisisnic
apacheGH-40274: [C++] Add support for system glog 0.7 (apache#40275)
8eb7fb4 
### Rationale for this change

glog uses "glog" not "GLOG" as CMake package name. So we should follow it.

### What changes are included in this PR?

Use "glogAlt" for our glog CMake module name to distinct upstream's CMake package name. 

### Are these changes tested?

No. We don't have CI with glog 0.7 yet.

### Are there any user-facing changes?

Yes.
* GitHub Issue: apache#40274

Lead-authored-by: Sutou Kouhei <kou@clear-code.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Component: Python
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
2 participants
@kou @bnavigator