-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++][CI] AppVeyor build is failed by "Non-compatible flatbuffers version included" #40500
Comments
The nightly |
Hmm, I think we could simply remove |
It started failing simply because the flatbuffers version on conda-forge was bumped from 23.5.26, which is the version of our vendored header files, to 24.3.27. 24.3.27 was release 5 days ago: https://github.com/google/flatbuffers/releases/tag/v24.3.7 |
(we can also update our vendored headers and generated files, but there doesn't seem to be a pressing need given the changelog) |
Use `arrow::flatbuffers` as the first link library to prioritize bundled FlatBuffers than system FlatBuffers.
Thanks for the FlatBuffers' version information. I agree with its related but our build must not be failed even when we have different system FlatBuffers. |
#40521 for vendored FlatBuffers update. |
#40540 for not installing FlatBuffers. |
### Rationale for this change We'rebundling FlatBuffers and generated files by FlatBuffers. If we use system FlatBuffers that is different version of bundled one, we got a build error. ### What changes are included in this PR? Use `arrow::flatbuffers` as the first link library to prioritize bundled FlatBuffers than system FlatBuffers. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #40500 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Issue resolved by pull request 40519 |
Describe the bug, including details regarding any error messages, version, and platform.
#40446 may be related.
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/49371331#L1739
Component(s)
C++, Continuous Integration
The text was updated successfully, but these errors were encountered: