[Java][FlightSQL] Cleanup flightsql jdbc driver dependencies #40952
Comments
laurentgo
added a commit
to laurentgo/arrow
that referenced
this issue
Apr 2, 2024
…endencies Module `flight-sql-jdbc-driver` declares multiple dependencies, some (joda and bytebuddy) are not used anymore (but still packaged). Clean up list of dependencies declared in flight-sql-jdbc-driver modules as all of them are transitive dependencies from flight-sql-jdbc-core.
lidavidm
pushed a commit
that referenced
this issue
Apr 3, 2024
…ies (#40953) ### Rationale for this change Module `flight-sql-jdbc-driver` declares multiple dependencies, some (joda) are not used anymore (but still packaged). ### What changes are included in this PR? Clean up list of dependencies declared in flight-sql-jdbc-driver modules as all of them are transitive dependencies from flight-sql-jdbc-core. ### Are these changes tested? Yes: build + existing shading test ### Are there any user-facing changes? No * GitHub Issue: #40952 Authored-by: Laurent Goujon <laurent@apache.org> Signed-off-by: David Li <li.davidm96@gmail.com>
|
Issue resolved by pull request 40953 |
tolleybot
pushed a commit
to tmct/arrow
that referenced
this issue
May 2, 2024
…endencies (apache#40953) ### Rationale for this change Module `flight-sql-jdbc-driver` declares multiple dependencies, some (joda) are not used anymore (but still packaged). ### What changes are included in this PR? Clean up list of dependencies declared in flight-sql-jdbc-driver modules as all of them are transitive dependencies from flight-sql-jdbc-core. ### Are these changes tested? Yes: build + existing shading test ### Are there any user-facing changes? No * GitHub Issue: apache#40952 Authored-by: Laurent Goujon <laurent@apache.org> Signed-off-by: David Li <li.davidm96@gmail.com>
tolleybot
pushed a commit
to tmct/arrow
that referenced
this issue
May 4, 2024
…endencies (apache#40953) ### Rationale for this change Module `flight-sql-jdbc-driver` declares multiple dependencies, some (joda) are not used anymore (but still packaged). ### What changes are included in this PR? Clean up list of dependencies declared in flight-sql-jdbc-driver modules as all of them are transitive dependencies from flight-sql-jdbc-core. ### Are these changes tested? Yes: build + existing shading test ### Are there any user-facing changes? No * GitHub Issue: apache#40952 Authored-by: Laurent Goujon <laurent@apache.org> Signed-off-by: David Li <li.davidm96@gmail.com>
rok
pushed a commit
to tmct/arrow
that referenced
this issue
May 8, 2024
…endencies (apache#40953) ### Rationale for this change Module `flight-sql-jdbc-driver` declares multiple dependencies, some (joda) are not used anymore (but still packaged). ### What changes are included in this PR? Clean up list of dependencies declared in flight-sql-jdbc-driver modules as all of them are transitive dependencies from flight-sql-jdbc-core. ### Are these changes tested? Yes: build + existing shading test ### Are there any user-facing changes? No * GitHub Issue: apache#40952 Authored-by: Laurent Goujon <laurent@apache.org> Signed-off-by: David Li <li.davidm96@gmail.com>
rok
pushed a commit
to tmct/arrow
that referenced
this issue
May 8, 2024
…endencies (apache#40953) ### Rationale for this change Module `flight-sql-jdbc-driver` declares multiple dependencies, some (joda) are not used anymore (but still packaged). ### What changes are included in this PR? Clean up list of dependencies declared in flight-sql-jdbc-driver modules as all of them are transitive dependencies from flight-sql-jdbc-core. ### Are these changes tested? Yes: build + existing shading test ### Are there any user-facing changes? No * GitHub Issue: apache#40952 Authored-by: Laurent Goujon <laurent@apache.org> Signed-off-by: David Li <li.davidm96@gmail.com>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this issue
May 25, 2024
…endencies (apache#40953) ### Rationale for this change Module `flight-sql-jdbc-driver` declares multiple dependencies, some (joda) are not used anymore (but still packaged). ### What changes are included in this PR? Clean up list of dependencies declared in flight-sql-jdbc-driver modules as all of them are transitive dependencies from flight-sql-jdbc-core. ### Are these changes tested? Yes: build + existing shading test ### Are there any user-facing changes? No * GitHub Issue: apache#40952 Authored-by: Laurent Goujon <laurent@apache.org> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
The module
flight-sql-jdbc-driverdeclares explicitly multiple dependencies which would be transitively captured if the module would only depend onflight-sql-driver-core. This can cause the module to declare dependencies which are not used anymore, or use a different version compared to what was declared in other modules. Indeed, the driver includesjodadependency which is not used in the rest of the code anymore.Component(s)
Java
The text was updated successfully, but these errors were encountered: