Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Java] Crossbow verify-rc-source-java-macos-amd64 fails with a format error in configs #41088

Closed
vibhatha opened this issue Apr 9, 2024 · 3 comments

Comments

@vibhatha
Copy link
Collaborator

vibhatha commented Apr 9, 2024

Describe the bug, including details regarding any error messages, version, and platform.

A workflow file format issue has been found in https://github.com/ursacomputing/crossbow/actions/runs/8606378683/workflow while running Java crossbows.

Component(s)

Java

@vibhatha vibhatha changed the title [CI] Java Crossbow verify-rc-source-java-macos-amd64 fails with a format error in configs [CI] [Java] Crossbow verify-rc-source-java-macos-amd64 fails with a format error in configs Apr 9, 2024
@kou
Copy link
Member

kou commented Apr 9, 2024

This is caused in #40537 by me...

@kou
Copy link
Member

kou commented Apr 9, 2024

I was wrong. #40949 broke this.

@kou kou changed the title [CI] [Java] Crossbow verify-rc-source-java-macos-amd64 fails with a format error in configs [CI][Java] Crossbow verify-rc-source-java-macos-amd64 fails with a format error in configs Apr 9, 2024
kou added a commit to kou/arrow that referenced this issue Apr 9, 2024
We can't use multiple top-level `env:` in workflow. apacheGH-40949
introduced a top-level `env:` by `macros.github_header()`. It broke
workflows that already have top-level `env:`.
@kou kou added this to the 16.0.0 milestone Apr 9, 2024
kou added a commit that referenced this issue Apr 9, 2024
…1091)

### Rationale for this change

We can't use multiple top-level `env:` in workflow. GH-40949 introduced a top-level `env:` by `macros.github_header()`. It broke workflows that already have top-level `env:`.

### What changes are included in this PR?

Omit top-level `env:` key and reuse the top-level `env:` key generated by `macros.github_header()` in workflows.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #41088

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou
Copy link
Member

kou commented Apr 9, 2024

Issue resolved by pull request 41091
#41091

@kou kou closed this as completed Apr 9, 2024
raulcd pushed a commit that referenced this issue Apr 10, 2024
…1091)

### Rationale for this change

We can't use multiple top-level `env:` in workflow. GH-40949 introduced a top-level `env:` by `macros.github_header()`. It broke workflows that already have top-level `env:`.

### What changes are included in this PR?

Omit top-level `env:` key and reuse the top-level `env:` key generated by `macros.github_header()` in workflows.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #41088

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue Apr 15, 2024
…or (apache#41091)

### Rationale for this change

We can't use multiple top-level `env:` in workflow. apacheGH-40949 introduced a top-level `env:` by `macros.github_header()`. It broke workflows that already have top-level `env:`.

### What changes are included in this PR?

Omit top-level `env:` key and reuse the top-level `env:` key generated by `macros.github_header()` in workflows.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41088

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
…or (apache#41091)

### Rationale for this change

We can't use multiple top-level `env:` in workflow. apacheGH-40949 introduced a top-level `env:` by `macros.github_header()`. It broke workflows that already have top-level `env:`.

### What changes are included in this PR?

Omit top-level `env:` key and reuse the top-level `env:` key generated by `macros.github_header()` in workflows.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41088

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
…or (apache#41091)

### Rationale for this change

We can't use multiple top-level `env:` in workflow. apacheGH-40949 introduced a top-level `env:` by `macros.github_header()`. It broke workflows that already have top-level `env:`.

### What changes are included in this PR?

Omit top-level `env:` key and reuse the top-level `env:` key generated by `macros.github_header()` in workflows.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41088

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants