Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Release] verify-rc-source-ruby-linux-conda-latest-amd64 fails generating arrow-glib/Arrow-1.0.gir due to not found GObject-2.0.gir #41167

Closed
raulcd opened this issue Apr 12, 2024 · 5 comments

Comments

@raulcd
Copy link
Member

raulcd commented Apr 12, 2024

Describe the bug, including details regarding any error messages, version, and platform.

The verify-rc-source-ruby-linux-conda-latest-amd64 job has been failing for some time with the following error:

[52/102] Generating arrow-glib/Arrow-1.0.gir with a custom command (wrapped by meson to set env)
FAILED: arrow-glib/Arrow-1.0.gir 
env PKG_CONFIG_PATH=/tmp/arrow-HEAD.xDBIu/install/lib/pkgconfig:/tmp/arrow-HEAD.xDBIu/c-glib-build/meson-uninstalled PKG_CONFIG=/tmp/arrow-HEAD.xDBIu/mambaforge/envs/conda-source/bin/pkg-config CC=/tmp/arrow-HEAD.xDBIu/mambaforge/envs/conda-source/bin/x86_64-conda-linux-gnu-cc /tmp/arrow-HEAD.xDBIu/mambaforge/envs/conda-source/bin/g-ir-scanner --quiet --no-libtool --namespace=Arrow --nsversion=1.0 --warn-all --output arrow-glib/Arrow-1.0.gir --c-include=arrow-glib/arrow-glib.h --warn-all -I/arrow/c_glib/arrow-glib -I/tmp/arrow-HEAD.xDBIu/c-glib-build/arrow-glib -I/arrow/c_glib/. -I/tmp/arrow-HEAD.xDBIu/c-glib-build/. --filelist=/tmp/arrow-HEAD.xDBIu/c-glib-build/arrow-glib/libarrow-glib.so.1600.0.0.p/Arrow_1.0_gir_filelist --include=GObject-2.0 --include=Gio-2.0 --symbol-prefix=garrow --identifier-prefix=GArrow --pkg-export=arrow-glib --cflags-begin -I/arrow/c_glib/. -I/tmp/arrow-HEAD.xDBIu/c-glib-build/. -DUTF8PROC_EXPORTS -I/tmp/arrow-HEAD.xDBIu/install/include -I/tmp/arrow-HEAD.xDBIu/mambaforge/envs/conda-source/include -I/tmp/arrow-HEAD.xDBIu/mambaforge/envs/conda-source/include/glib-2.0 -I/tmp/arrow-HEAD.xDBIu/mambaforge/envs/conda-source/lib/glib-2.0/include -I/tmp/arrow-HEAD.xDBIu/mambaforge/envs/conda-source/include/gobject-introspection-1.0 -DNDEBUG --cflags-end --add-include-path=/tmp/arrow-HEAD.xDBIu/mambaforge/envs/conda-source/share/gir-1.0 -L/tmp/arrow-HEAD.xDBIu/c-glib-build/arrow-glib --library arrow-glib -L/tmp/arrow-HEAD.xDBIu/install/lib -L/tmp/arrow-HEAD.xDBIu/mambaforge/envs/conda-source/lib -L/tmp/arrow-HEAD.xDBIu/install/lib --extra-library=arrow --extra-library=arrow_acero -L/tmp/arrow-HEAD.xDBIu/mambaforge/envs/conda-source/lib --extra-library=gobject-2.0 --extra-library=glib-2.0 --extra-library=girepository-1.0 --sources-top-dirs /arrow/c_glib/ --sources-top-dirs /tmp/arrow-HEAD.xDBIu/c-glib-build/
Couldn't find include 'GObject-2.0.gir' (search path: '['/tmp/arrow-HEAD.xDBIu/mambaforge/envs/conda-source/share/gir-1.0', '/root/.local/share/gir-1.0', 'gir-1.0', '/usr/local/share/gir-1.0', '/usr/share/gir-1.0', '/tmp/arrow-HEAD.xDBIu/mambaforge/envs/conda-source/share/gir-1.0', '/tmp/arrow-HEAD.xDBIu/mambaforge/envs/conda-source/share/gir-1.0', '/usr/share/gir-1.0']')
[53/102] Compiling C++ object arrow-dataset-glib/libarrow-dataset-glib.so.1600.0.0.p/file-format.cpp.o
[54/102] Compiling C++ object arrow-dataset-glib/libarrow-dataset-glib.so.1600.0.0.p/partitioning.cpp.o
[55/102] Compiling C++ object arrow-dataset-glib/libarrow-dataset-glib.so.1600.0.0.p/scanner.cpp.o
[56/102] Compiling C++ object arrow-flight-glib/libarrow-flight-glib.so.1600.0.0.p/client.cpp.o
[57/102] Compiling C++ object arrow-flight-glib/libarrow-flight-glib.so.1600.0.0.p/common.cpp.o
ninja: build stopped: subcommand failed.

It started failing when this commits where introduced (5ddef63...469430f) but I don't see anything relevant to the failure.

Component(s)

Continuous Integration, Release

@raulcd
Copy link
Member Author

raulcd commented Apr 12, 2024

It is fixed if I pin gobject-introspection=1.78.1.

diff --git a/dev/release/verify-release-candidate.sh b/dev/release/verify-release-candidate.sh
index f18b18a..9cb5cee 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -831,7 +831,7 @@ test_glib() {
   show_header "Build and test C GLib libraries"
 
   # Build and test C GLib
-  maybe_setup_conda glib gobject-introspection meson ninja ruby
+  maybe_setup_conda glib gobject-introspection=1.78.1 meson ninja ruby
   maybe_setup_virtualenv meson
 
   # Install bundler if doesn't exist

but doesn't seem to work with the newest 1.80, @kou any suggestion? Should I just pin?

@raulcd raulcd added this to the 16.0.0 milestone Apr 12, 2024
@kou
Copy link
Member

kou commented Apr 12, 2024

We need conda-forge/glib-feedstock#174 but it's still WIP.
So we can pin for now.

kou added a commit that referenced this issue Apr 13, 2024
…8.1 (#41181)

### Rationale for this change

GObject Introspection is merging into GLib. It's not completed yet.

GLib related `.gir` files are moved to GLib from GObject Introspection since GLib/GObject Introspection 2.80.0. But glib 2.80.0 conda package doesn't support this merge yet:  conda-forge/glib-feedstock#174

### What changes are included in this PR?

Pin gobject-introspection to 1.78.1 for now. 

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #41167

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou
Copy link
Member

kou commented Apr 13, 2024

Issue resolved by pull request 41181
#41181

@kou kou closed this as completed Apr 13, 2024
vibhatha pushed a commit to vibhatha/arrow that referenced this issue Apr 15, 2024
…to 1.78.1 (apache#41181)

### Rationale for this change

GObject Introspection is merging into GLib. It's not completed yet.

GLib related `.gir` files are moved to GLib from GObject Introspection since GLib/GObject Introspection 2.80.0. But glib 2.80.0 conda package doesn't support this merge yet:  conda-forge/glib-feedstock#174

### What changes are included in this PR?

Pin gobject-introspection to 1.78.1 for now. 

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41167

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
raulcd pushed a commit that referenced this issue Apr 15, 2024
…8.1 (#41181)

### Rationale for this change

GObject Introspection is merging into GLib. It's not completed yet.

GLib related `.gir` files are moved to GLib from GObject Introspection since GLib/GObject Introspection 2.80.0. But glib 2.80.0 conda package doesn't support this merge yet:  conda-forge/glib-feedstock#174

### What changes are included in this PR?

Pin gobject-introspection to 1.78.1 for now. 

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #41167

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@xhochy
Copy link
Member

xhochy commented Apr 15, 2024

This is resolved now and you should be able to remove the pin.

@kou
Copy link
Member

kou commented Apr 16, 2024

Thanks!
Let's try it! #41227

tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
…to 1.78.1 (apache#41181)

### Rationale for this change

GObject Introspection is merging into GLib. It's not completed yet.

GLib related `.gir` files are moved to GLib from GObject Introspection since GLib/GObject Introspection 2.80.0. But glib 2.80.0 conda package doesn't support this merge yet:  conda-forge/glib-feedstock#174

### What changes are included in this PR?

Pin gobject-introspection to 1.78.1 for now. 

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41167

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
tolleybot pushed a commit to tmct/arrow that referenced this issue May 4, 2024
…to 1.78.1 (apache#41181)

### Rationale for this change

GObject Introspection is merging into GLib. It's not completed yet.

GLib related `.gir` files are moved to GLib from GObject Introspection since GLib/GObject Introspection 2.80.0. But glib 2.80.0 conda package doesn't support this merge yet:  conda-forge/glib-feedstock#174

### What changes are included in this PR?

Pin gobject-introspection to 1.78.1 for now. 

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41167

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
…to 1.78.1 (apache#41181)

### Rationale for this change

GObject Introspection is merging into GLib. It's not completed yet.

GLib related `.gir` files are moved to GLib from GObject Introspection since GLib/GObject Introspection 2.80.0. But glib 2.80.0 conda package doesn't support this merge yet:  conda-forge/glib-feedstock#174

### What changes are included in this PR?

Pin gobject-introspection to 1.78.1 for now. 

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41167

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
…to 1.78.1 (apache#41181)

### Rationale for this change

GObject Introspection is merging into GLib. It's not completed yet.

GLib related `.gir` files are moved to GLib from GObject Introspection since GLib/GObject Introspection 2.80.0. But glib 2.80.0 conda package doesn't support this merge yet:  conda-forge/glib-feedstock#174

### What changes are included in this PR?

Pin gobject-introspection to 1.78.1 for now. 

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41167

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
…to 1.78.1 (apache#41181)

### Rationale for this change

GObject Introspection is merging into GLib. It's not completed yet.

GLib related `.gir` files are moved to GLib from GObject Introspection since GLib/GObject Introspection 2.80.0. But glib 2.80.0 conda package doesn't support this merge yet:  conda-forge/glib-feedstock#174

### What changes are included in this PR?

Pin gobject-introspection to 1.78.1 for now. 

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41167

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants