Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release][Packaging] Skip needless download by "archery crossbow download-artifacts" #41243

Closed
kou opened this issue Apr 17, 2024 · 1 comment

Comments

@kou
Copy link
Member

kou commented Apr 17, 2024

Describe the enhancement requested

dev/release/04-binary-download.sh uses archery crossbow download-artifacts to download built artifacts.
It always download all target artifacts. If we get an error while dev/release/04-binary-download.sh and re-run it, it downloads already downloaded artifacts too. We can avoid these downloads.

Component(s)

Packaging, Release

kou added a commit to kou/arrow that referenced this issue Apr 17, 2024
kou added a commit that referenced this issue Apr 18, 2024
…ossbow download-artifacts" (#41244)

### Rationale for this change

We don't need to re-download already downloaded artifacts.

### What changes are included in this PR?

Check local path and skip download if there is downloaded artifact on local.
 
### Are these changes tested?

Yes. I've tested this with 16.0.0 RC0 release.

### Are there any user-facing changes?

No.
* GitHub Issue: #41243

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 17.0.0 milestone Apr 18, 2024
@kou
Copy link
Member Author

kou commented Apr 18, 2024

Issue resolved by pull request 41244
#41244

@kou kou closed this as completed Apr 18, 2024
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
…ery crossbow download-artifacts" (apache#41244)

### Rationale for this change

We don't need to re-download already downloaded artifacts.

### What changes are included in this PR?

Check local path and skip download if there is downloaded artifact on local.
 
### Are these changes tested?

Yes. I've tested this with 16.0.0 RC0 release.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41243

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
…ery crossbow download-artifacts" (apache#41244)

### Rationale for this change

We don't need to re-download already downloaded artifacts.

### What changes are included in this PR?

Check local path and skip download if there is downloaded artifact on local.
 
### Are these changes tested?

Yes. I've tested this with 16.0.0 RC0 release.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41243

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant