Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Minor code enhancement for ipc writer #41899

Closed
mapleFU opened this issue May 31, 2024 · 1 comment
Closed

[C++] Minor code enhancement for ipc writer #41899

mapleFU opened this issue May 31, 2024 · 1 comment
Assignees
@mapleFU
Labels
Component: C++ Type: enhancement
Milestone
17.0.0

Comments

@mapleFU
Copy link
Member

mapleFU commented May 31, 2024

Describe the enhancement requested

When I go through the code of IPC writer, it buffer always uses put, and some times reinterpret_cast is used. This could be enhanced

Component(s)

C++
@github-actions github-actions bot mentioned this issue May 31, 2024
Merged
mapleFU added a commit that referenced this issue Jun 11, 2024
@mapleFU
GH-41899: [C++] IPC: Minor enhance the code of writer (#41900)
64b1109 
### Rationale for this change

Enhance the code of IPC writer

### What changes are included in this PR?

1. memcpy rather than reinterpret_cast
2. move the buffer rather than copying

### Are these changes tested?

Covered by existing

### Are there any user-facing changes?

No

* GitHub Issue: #41899

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: mwish <maplewish117@gmail.com>
@mapleFU mapleFU added this to the 17.0.0 milestone Jun 11, 2024
@mapleFU
Copy link
Member Author

mapleFU commented Jun 11, 2024

Issue resolved by pull request 41900
#41900

@mapleFU mapleFU closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapleFU mapleFU

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
1 participant
@mapleFU