Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-12421: [Rust] [DataFusion] Disable repartition rule #10069

Closed
wants to merge 1 commit into from

Conversation

andygrove
Copy link
Member

Remove repartition rule to fix test regression when running on 24 core threadripper CPU.

This will need further investigation but this patch is needed for the 4.0.0 release.

@alamb alamb changed the title ARROW-12421: [Rust] [DataFusion] Remove repartition rule ARROW-12421: [Rust] [DataFusion] Disable repartition rule Apr 16, 2021
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we also file a ticket (I can do so if you would like) to investigate and re-enable this optimization

@github-actions
Copy link

Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andygrove !

@andygrove
Copy link
Member Author

I suggest we also file a ticket (I can do so if you would like) to investigate and re-enable this optimization

That would be great. Thanks.

Copy link
Member

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Thanks for the quick fix on this!

@alamb alamb closed this in 9c1e5bd Apr 16, 2021
@alamb
Copy link
Contributor

alamb commented Apr 16, 2021

Additional discussion on ASF slack is here: https://the-asf.slack.com/archives/C01QUFS30TD/p1618578254185400 may be related to #9865

@alamb
Copy link
Contributor

alamb commented Apr 16, 2021

Filed https://issues.apache.org/jira/browse/ARROW-12427 to track reenabling this optimization rule

GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
Remove repartition rule to fix test regression when running on 24 core threadripper CPU.

This will need further investigation but this patch is needed for the 4.0.0 release.

Closes apache#10069 from andygrove/remove-repartition

Authored-by: Andy Grove <andygrove73@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 10, 2021
Remove repartition rule to fix test regression when running on 24 core threadripper CPU.

This will need further investigation but this patch is needed for the 4.0.0 release.

Closes apache#10069 from andygrove/remove-repartition

Authored-by: Andy Grove <andygrove73@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 13, 2021
Remove repartition rule to fix test regression when running on 24 core threadripper CPU.

This will need further investigation but this patch is needed for the 4.0.0 release.

Closes apache#10069 from andygrove/remove-repartition

Authored-by: Andy Grove <andygrove73@gmail.com>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants