-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-12485: [C++] Use mimalloc as the default memory allocator on macOS #10117
Conversation
I'm not sure if |
@github-actions autotune |
The MacOS build failures are related to https://issues.apache.org/jira/browse/ARROW-12467 and the MinGW are unrelated to this change (and are failing on master) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but be sure to test that it selects the right backend on macOS :-)
return MemoryPoolBackend::System; | ||
#endif | ||
struct SupportedBackend default_backend = SupportedBackends().front(); | ||
return default_backend.backend; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or simply:
return SupportedBackends().front().backend;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I did test this locally to make sure, and it works like I expected it to: mimalloc is default with no ARROW_DEFAULT_MEMORY_POOL
set and also with a ARROW_DEFAULT_MEMORY_POOL
set that is not supported / non existent.
Thanks!
Closes apache#10117 from jonkeane/ARROW-12485 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Closes apache#10117 from jonkeane/ARROW-12485 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Closes apache#10117 from jonkeane/ARROW-12485 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
No description provided.