ARROW-12485: [C++] Use mimalloc as the default memory allocator on macOS #10117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if |
|
@github-actions autotune |
|
The MacOS build failures are related to https://issues.apache.org/jira/browse/ARROW-12467 and the MinGW are unrelated to this change (and are failing on master) |
pitrou
approved these changes
Apr 21, 2021
| return MemoryPoolBackend::System; | ||
| #endif | ||
| struct SupportedBackend default_backend = SupportedBackends().front(); | ||
| return default_backend.backend; |
There was a problem hiding this comment.
Or simply:
return SupportedBackends().front().backend;There was a problem hiding this comment.
Yup, I did test this locally to make sure, and it works like I expected it to: mimalloc is default with no ARROW_DEFAULT_MEMORY_POOL set and also with a ARROW_DEFAULT_MEMORY_POOL set that is not supported / non existent.
Thanks!
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
Closes apache#10117 from jonkeane/ARROW-12485 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 10, 2021
Closes apache#10117 from jonkeane/ARROW-12485 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
Closes apache#10117 from jonkeane/ARROW-12485 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.