ARROW-12907: [Java] Fix memory leak on deserialization errors #10423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @liyafan82 or @lidavidm would you mind reviewing? |
|
In practice this can happen if the thread running this code is interrupted. |
@emkornfield Thank you for working on this. I will take a look two or three days later, when I come back from vocation. |
|
Good catch, the fix looks good. |
lidavidm
approved these changes
May 30, 2021
liyafan82
reviewed
Jun 2, 2021
| batch.close(); | ||
|
|
||
| { | ||
| ByteArrayInputStream in = new ByteArrayInputStream(out.toByteArray()); |
There was a problem hiding this comment.
It would be nice to wrap this into a try-with-resource block.
|
Merging. Thanks for the PR. @emkornfield |
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
Closes apache#10423 from emkornfield/ARROW-12907 Authored-by: Micah Kornfield <emkornfield@gmail.com> Signed-off-by: liyafan82 <fan_li_ya@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.