ARROW-12901: [R] Follow on to more examples #10436
Conversation
|
WRT @jonkeane 's questions on the JIRA ticket:
Yep - have updated now!
Nice, that's made that code a LOT nicer to look at.
Yeah, I will add something in about that next. |
|
@jonkeane - how does this look now? |
|
@github-actions crossbow submit test-r-without-arrow |
|
Revision: d9bd85e Submitted crossbow builds: ursacomputing/crossbow @ actions-465
|
There was a problem hiding this comment.
This is looking good. A few more suggestions / comments now that I'm seeing it written out. We should also probably wait for #10455 to merge before we send this one so we can rebase + run the tests here and make sure that's all sorted.
Additionally, I noticed that a lot of this content is in the long running + starting/stoping PR #9748 as well. The only thing that isn't here that is in #9748 is some reference to how df %>% group_by("foo", "bar") %>% write_dataset(...) is the same thing as write_dataset(df, partitioning = c("foo", "bar")) maybe we could add an example or two of that and then close there other PR?
| #' # This line will work | ||
| #' open_dataset(tf2, format = "ipc") | ||
| #' | ||
| #' ## You can specify file partitioning to include it as a field in your dataset |
There was a problem hiding this comment.
is the double-# intentional here?
There was a problem hiding this comment.
Yep, I was trying to use it to specify a new section - however, if this isn't widely done, maybe I should do it differently?
There was a problem hiding this comment.
We can keep it there — I don't think there's a standard pattern either in the package or elsewhere (that I know of, but let me know if you know of the state of art in other packages!)
r/R/dataset.R
Outdated
| #' md_schema <- schema(Month = int8(), Day = int8()) | ||
| #' | ||
| #' # Now that partitioning has been specified, your dataset contains columns for Month and Day | ||
| #' open_dataset(tf3, partitioning = md_schema) |
There was a problem hiding this comment.
Could we also include the simpler version of this too?
open_dataset(tf3, partitioning = c("Month", "Day"))
That PR is for |
thisisnic
force-pushed
the
ARROW-12901_examples
branch
from
d9bd85e
to
355255b
Compare
Ah, right of course. Yeah, it might be good to harmonize them (or maybe even combine them into one page?) But regardless we can do that on a follow on (or on that other ticket), we don't need to do that in this one. |
|
@github-actions crossbow submit test-r-without-arrow |
|
Revision: 355255b Submitted crossbow builds: ursacomputing/crossbow @ actions-485
|
|
@github-actions crossbow submit test-r-minimal-build |
|
Revision: 355255b Submitted crossbow builds: ursacomputing/crossbow @ actions-486
|
|
This looks good, I've run the two builds we had issues with in the past. This shouldn't be necessary, but just in case I'll also run |
|
@github-actions crossbow submit -g r |
|
Revision: 355255b Submitted crossbow builds: ursacomputing/crossbow @ actions-487
|
Closes apache#10436 from thisisnic/ARROW-12901_examples Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
No description provided.