Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-11729: [R] Add examples to datasets documentation #9748

Closed
wants to merge 16 commits into from
Closed

ARROW-11729: [R] Add examples to datasets documentation #9748

wants to merge 16 commits into from

Conversation

pachadotdev
Copy link
Contributor

No description provided.

jonkeane
jonkeane requested changes Mar 18, 2021
View reviewed changes
Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, a few comments and suggestions

r/R/dataset-write.R Outdated Show resolved Hide resolved
r/R/dataset-write.R Outdated Show resolved Hide resolved
r/R/dataset-write.R Outdated Show resolved Hide resolved
r/R/dataset-write.R Outdated Show resolved Hide resolved
r/R/dataset-write.R Outdated Show resolved Hide resolved
r/R/dataset-write.R Outdated Show resolved Hide resolved
r/R/dataset-write.R Outdated Show resolved Hide resolved
r/R/dataset-write.R Outdated Show resolved Hide resolved
r/R/dataset-write.R Outdated Show resolved Hide resolved
r/R/dataset-write.R Outdated Show resolved Hide resolved
Pachamaltese and others added 6 commits March 18, 2021 11:09
@jonkeane
Update r/R/dataset-write.R
cfe7d73 
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
@jonkeane
Update r/R/dataset-write.R
e313b66 
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
@jonkeane
Update r/R/dataset-write.R
dd3b6d4 
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
@jonkeane
Update r/R/dataset-write.R
9493680 
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
@jonkeane
Update r/R/dataset-write.R
81016c0 
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
@jonkeane
Update r/R/dataset-write.R
25bffbe 
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-11729

@kou kou changed the title ARROW-11729 adding examples again ARROW-11729: [R] Add examples to datasets documentation Mar 18, 2021
jonkeane
jonkeane requested changes Apr 19, 2021
View reviewed changes
r/R/dataset-write.R Outdated Show resolved Hide resolved
consistent description with code example in L87-89
594713b 
consistent description with code example in L87-89
thisisnic
thisisnic requested changes May 12, 2021
View reviewed changes
r/R/dataset-write.R Show resolved Hide resolved
r/R/dataset-write.R Outdated Show resolved Hide resolved
r/R/dataset-write.R Show resolved Hide resolved
r/R/dataset-write.R Show resolved Hide resolved
@thisisnic thisisnic mentioned this pull request Jun 8, 2021
Closed
jonkeane
jonkeane requested changes Aug 26, 2021
View reviewed changes
Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting there. I've made a number of suggestions / requests for changes. Please either (re)request me to review this when it's completed or write a comment when this is ready for review so I know to look at it again.

r/R/dataset-write.R Outdated Show resolved Hide resolved
r/R/dataset-write.R Outdated Show resolved Hide resolved
r/R/dataset-write.R Outdated Show resolved Hide resolved
r/R/dataset-write.R Outdated Show resolved Hide resolved
r/R/dataset-write.R Outdated Show resolved Hide resolved
r/R/dataset-write.R Outdated Show resolved Hide resolved
r/R/dataset-write.R Outdated Show resolved Hide resolved
Pachá and others added 3 commits August 26, 2021 16:47
@jonkeane
Update r/R/dataset-write.R
5b5cffc 
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
@jonkeane
Update r/R/dataset-write.R
730a322 
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
@pachadotdev
Jon's feedback
8172d3e
@pachadotdev
Copy link
Contributor Author

thanks @jonkeane ! I implemented all the changes and also moves single %>%s to expressions like group_by(mtcars, ...)

jonkeane
jonkeane requested changes Aug 27, 2021
View reviewed changes
Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking better, one last structure comment. Once you address that this should be good to go.

r/R/dataset-write.R Outdated Show resolved Hide resolved
jonkeane
jonkeane reviewed Aug 27, 2021
View reviewed changes
r/R/dataset-write.R Outdated Show resolved Hide resolved
@jonkeane
Copy link
Member

@github-actions autotune

@jonkeane jonkeane closed this in 1609128 Aug 27, 2021
@asfimport asfimport mentioned this pull request Aug 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonkeane jonkeane jonkeane requested changes

@thisisnic thisisnic thisisnic requested changes

Assignees
No one assigned
Labels
Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pachadotdev @jonkeane @thisisnic