Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-13277: [JS] Add declaration maps for TypeScript and refactor testing infrastructure #10673

Closed
wants to merge 23 commits into from
Closed

ARROW-13277: [JS] Add declaration maps for TypeScript and refactor testing infrastructure #10673

wants to merge 23 commits into from

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Jul 7, 2021

With declaration maps, developers can jump to the implementation rather than a declaration file.

@github-actions
Copy link

github-actions bot commented Jul 7, 2021

https://issues.apache.org/jira/browse/ARROW-13277

@domoritz domoritz changed the title ARROW-13277: [JS] Add declaration maps ARROW-13277: [JS] Add declaration maps for TypeScript Jul 7, 2021
trxcllnt
trxcllnt approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@trxcllnt trxcllnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 I love declaration maps 🎉

domoritz
domoritz commented Jul 7, 2021
View reviewed changes
js/jest.config.js Outdated Show resolved Hide resolved
@domoritz domoritz mentioned this pull request Jul 7, 2021
Closed
@domoritz domoritz requested a review from trxcllnt July 10, 2021 20:58
@domoritz domoritz mentioned this pull request Jul 10, 2021
Closed
@domoritz domoritz changed the title ARROW-13277: [JS] Add declaration maps for TypeScript ARROW-13277: [JS] Add declaration maps for TypeScript and refactor testing infrastructure Jul 11, 2021
@domoritz
Copy link
Member Author

domoritz commented Jul 11, 2021 •
edited
Loading

Hmm, can it be that test times for the docker build went from 20 minutes to 50 minutes? (https://github.com/apache/arrow/runs/3005016709 vs https://github.com/apache/arrow/runs/3037021755). The last run was faster again. Maybe the CI is just inconsistent.

This was referenced Jul 11, 2021
Closed
Closed
domoritz
domoritz commented Jul 12, 2021
View reviewed changes
Copy link
Member Author

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domoritz domoritz closed this in ba009fb Jul 12, 2021
domoritz added a commit that referenced this pull request Jul 15, 2021
@domoritz @trxcllnt
ARROW-13299: [JS] Upgrade ix and rxjs
5e43cde 
Merge after #10673, only the last commit is new

Closes #10695 from domoritz/dom/upgrades

Lead-authored-by: Dominik Moritz <domoritz@gmail.com>
Co-authored-by: ptaylor <paul.e.taylor@me.com>
Signed-off-by: Dominik Moritz <domoritz@gmail.com>
@asfimport asfimport mentioned this pull request Jul 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trxcllnt trxcllnt trxcllnt approved these changes

@TheNeuralBit TheNeuralBit Awaiting requested review from TheNeuralBit

Assignees
No one assigned
Labels
Component: JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domoritz @trxcllnt