ARROW-13323: [Archery] Validate docker compose configuration #10692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszucs
changed the title
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format? or See also: |
kszucs
commented
Jul 9, 2021
.github/workflows/archery.yml
Outdated
| @@ -62,7 +62,7 @@ jobs: | |||
| working-directory: dev/archery | |||
| run: pytest -v archery | |||
| - name: Archery Docker Validation | |||
| run: archery docker | |||
| run: archery docker validate-config | |||
There was a problem hiding this comment.
Click hasn't been executing the command initialization with a subcommand, effectively omitting the validation.
Although it has not caused any problems since the docker build and run commands verify the configuration.
There was a problem hiding this comment.
Should rename to check-config similarly to the crossbow config check command.
kszucs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will create a JIRA for it.