ARROW-12359: [C++] Deprecate FileSystem::OpenAppendStream #10874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonpace
approved these changes
Aug 5, 2021
There was a problem hiding this comment.
LGTM. There is also a spot here which could use the macro although hopefully I will be fixing that reference soon. I do agree with the general philosophy that "filesystem" isn't meant to be a general purpose utility and so anything that isn't used probably shouldn't be there.
This function is poorly supported accross filesystems and is not generally useful for the kind of data that Arrow accesses.
pitrou
force-pushed
the
ARROW-12359-deprecate-open-append-stream
branch
from
e72d5ff
to
c61b18e
Compare
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Aug 17, 2021
This function is poorly supported accross filesystems and is not generally useful for the kind of data that Arrow accesses. Closes apache#10874 from pitrou/ARROW-12359-deprecate-open-append-stream Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is poorly supported accross filesystems and is not generally useful for the kind of data that Arrow accesses.