-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-13575: [C++] Add hash_product kernel #10890
Conversation
@@ -47,6 +47,9 @@ using applicator::ScalarUnaryNotNull; | |||
|
|||
namespace { | |||
|
|||
// N.B. take care not to conflict with type_traits.h as that can cause surprises in a | |||
// unity build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-D
I opened https://issues.apache.org/jira/browse/ARROW-13595 to check for kernel output type mismatches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @lidavidm ! LGTM, will merge.
No description provided.