ARROW-14090: [C++][Parquet] rows_written_ should be int64_t instead of int #11217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format? or See also: |
cyb70289
reviewed
Sep 23, 2021
cyb70289
approved these changes
Sep 24, 2021
cyb70289
changed the title
|
|
ViniciusSouzaRoque
pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
…f int when we have a parquet file with only one row_group. And the row number is exceding 2^31, the num_rows_ became negative. Because the unexpected int type Closes apache#11217 from czxrrr/ARROW-14090 Lead-authored-by: czxrrr <caozherui@gmail.com> Co-authored-by: Zherui <caozherui@gmail.com> Signed-off-by: Yibo Cai <yibo.cai@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we have a parquet file with only one row_group.
And the row number is exceding 2^31, the num_rows_ became negative.
Because the unexpected int type