-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-14166: [C++] update vcpkg builtin baseline #11266
ARROW-14166: [C++] update vcpkg builtin baseline #11266
Conversation
Tested locally with |
@github-actions crossbow submit -g nightly |
Revision: f84f733 Submitted crossbow builds: ursacomputing/crossbow @ actions-861 |
Umm, there are some failures... I'm not sure the failures are related to this change... @ianmcook Could you confirm this change? |
If you think rebasing or running some tests locally can help troubleshoot this I am happy to do so. |
Thanks for working on this @coryan! test-build-vcpkg-win first started failing in the nightly Crossbow job on September 10. I have been away for some of the time since then and haven't had a chance to dig in and determine the cause. I'll try to find some time today or tomorrow to do that. We should try to get that test to pass before merging this. |
I opened ARROW-14208 to fix the issue that's causing test-build-vcpkg-win to fail |
f84f733
to
37c60bf
Compare
Rebased to pick the fixes for ARROW-14208, though it seems that there is a separate link problem that we should wait for too? |
@ianmcook Could you dig into the linker issue? |
Jira for the linker error is ARROW-14260. |
37c60bf
to
db56ecb
Compare
Is there something else I should do in this PR or can we merge it? |
@github-actions crossbow submit test-build-vcpkg-win |
Revision: db56ecb Submitted crossbow builds: ursacomputing/crossbow @ actions-971
|
db56ecb
to
154c3af
Compare
Rebased, looks like there was a related change a few days ago. |
@github-actions crossbow submit test-build-vcpkg-win |
Revision: 154c3af Submitted crossbow builds: ursacomputing/crossbow @ actions-1051
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Benchmark runs are scheduled for baseline = 4c2a8dd and contender = 61be051. 61be051 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Closes apache#11266 from coryan/ARROW-14166-update-vcpkg-builtin-baseline Authored-by: Carlos O'Ryan <coryan@google.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
No description provided.