Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-14392: [C++] Bundled gRPC misses bundled Abseil include path #11474

Closed
wants to merge 5 commits into from

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented Oct 20, 2021

Also adding a minimal docker based build..

@github-actions
Copy link

@@ -3592,6 +3603,7 @@ macro(build_google_cloud_cpp_storage)
# Curl is required on all platforms, but building it internally might also trip over S3's copy.
# For now, force its inclusion from the underlying system or fail.
find_package(CURL 7.47.0 REQUIRED)
find_package(OpenSSL ${ARROW_OPENSSL_REQUIRED_VERSION} REQUIRED)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise cmake -DARROW_GCS=ON .. without e.g. ARROW_FLIGHT=ON misses SSL

@kszucs
Copy link
Member Author

kszucs commented Oct 20, 2021

@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled

@github-actions
Copy link

Revision: 80d7fc0

Submitted crossbow builds: ursacomputing/crossbow @ actions-1014

Task Status
test-ubuntu-20.04-cpp-bundled Github Actions

@kszucs
Copy link
Member Author

kszucs commented Oct 20, 2021

@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled

@github-actions
Copy link

Revision: 21dd818

Submitted crossbow builds: ursacomputing/crossbow @ actions-1015

Task Status
test-ubuntu-20.04-cpp-bundled Github Actions

@kszucs
Copy link
Member Author

kszucs commented Oct 20, 2021

@github-actions crossbow submit -g packaging

@github-actions
Copy link

Revision: 21dd818

Submitted crossbow builds: ursacomputing/crossbow @ actions-1016

Task Status
almalinux-8-amd64 Github Actions
almalinux-8-arm64 TravisCI
amazon-linux-2-amd64 Github Actions
centos-7-amd64 Github Actions
centos-8-amd64 Github Actions
centos-8-arm64 TravisCI
debian-bookworm-amd64 Github Actions
debian-bookworm-arm64 TravisCI
debian-bullseye-amd64 Github Actions
debian-bullseye-arm64 TravisCI
debian-buster-amd64 Github Actions
debian-buster-arm64 TravisCI
java-jars Github Actions
nuget Github Actions
python-sdist Github Actions
ubuntu-bionic-amd64 Github Actions
ubuntu-bionic-arm64 TravisCI
ubuntu-focal-amd64 Github Actions
ubuntu-focal-arm64 TravisCI
ubuntu-hirsute-amd64 Github Actions
ubuntu-hirsute-arm64 TravisCI
wheel-macos-big-sur-cp310-arm64 Github Actions
wheel-macos-big-sur-cp310-universal2 Github Actions
wheel-macos-big-sur-cp38-arm64 Github Actions
wheel-macos-big-sur-cp39-arm64 Github Actions
wheel-macos-big-sur-cp39-universal2 Github Actions
wheel-macos-high-sierra-cp310-amd64 Github Actions
wheel-macos-high-sierra-cp36-amd64 Github Actions
wheel-macos-high-sierra-cp37-amd64 Github Actions
wheel-macos-high-sierra-cp38-amd64 Github Actions
wheel-macos-high-sierra-cp39-amd64 Github Actions
wheel-macos-mavericks-cp310-amd64 Github Actions
wheel-macos-mavericks-cp36-amd64 Github Actions
wheel-macos-mavericks-cp37-amd64 Github Actions
wheel-macos-mavericks-cp38-amd64 Github Actions
wheel-macos-mavericks-cp39-amd64 Github Actions
wheel-manylinux2010-cp310-amd64 Github Actions
wheel-manylinux2010-cp36-amd64 Github Actions
wheel-manylinux2010-cp37-amd64 Github Actions
wheel-manylinux2010-cp38-amd64 Github Actions
wheel-manylinux2010-cp39-amd64 Github Actions
wheel-manylinux2014-cp310-amd64 Github Actions
wheel-manylinux2014-cp310-arm64 TravisCI
wheel-manylinux2014-cp36-amd64 Github Actions
wheel-manylinux2014-cp36-arm64 TravisCI
wheel-manylinux2014-cp37-amd64 Github Actions
wheel-manylinux2014-cp37-arm64 TravisCI
wheel-manylinux2014-cp38-amd64 Github Actions
wheel-manylinux2014-cp38-arm64 TravisCI
wheel-manylinux2014-cp39-amd64 Github Actions
wheel-manylinux2014-cp39-arm64 TravisCI
wheel-windows-cp310-amd64 Github Actions
wheel-windows-cp36-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@kszucs kszucs requested a review from lidavidm October 20, 2021 12:51
@kszucs
Copy link
Member Author

kszucs commented Oct 20, 2021

The windows and macOS python 3.10 wheels are expected to fail due to missing numpy wheels.

@kszucs kszucs closed this in eb3c1bd Oct 20, 2021
@ursabot
Copy link

ursabot commented Oct 20, 2021

Benchmark runs are scheduled for baseline = 29892ba and contender = eb3c1bd. eb3c1bd is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.27% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@bkmgit
Copy link
Contributor

bkmgit commented Oct 20, 2021

@github-actions crossbow submit test-ubuntu-20.04-cpp-17

@github-actions
Copy link

Revision: 21dd818

Submitted crossbow builds: ursacomputing/crossbow @ actions-1019

Task Status
test-ubuntu-20.04-cpp-17 Github Actions

ViniciusSouzaRoque pushed a commit to s1mbi0se/arrow that referenced this pull request Nov 3, 2021
Also adding a minimal docker based build..

Closes apache#11474 from kszucs/abseil-include-dir

Authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants