-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-14392: [C++] Bundled gRPC misses bundled Abseil include path #11474
Conversation
@@ -3592,6 +3603,7 @@ macro(build_google_cloud_cpp_storage) | |||
# Curl is required on all platforms, but building it internally might also trip over S3's copy. | |||
# For now, force its inclusion from the underlying system or fail. | |||
find_package(CURL 7.47.0 REQUIRED) | |||
find_package(OpenSSL ${ARROW_OPENSSL_REQUIRED_VERSION} REQUIRED) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise cmake -DARROW_GCS=ON ..
without e.g. ARROW_FLIGHT=ON
misses SSL
@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled |
Revision: 80d7fc0 Submitted crossbow builds: ursacomputing/crossbow @ actions-1014
|
@github-actions crossbow submit test-ubuntu-20.04-cpp-bundled |
Revision: 21dd818 Submitted crossbow builds: ursacomputing/crossbow @ actions-1015
|
@github-actions crossbow submit -g packaging |
Revision: 21dd818 Submitted crossbow builds: ursacomputing/crossbow @ actions-1016 |
The windows and macOS python 3.10 wheels are expected to fail due to missing numpy wheels. |
Benchmark runs are scheduled for baseline = 29892ba and contender = eb3c1bd. eb3c1bd is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
@github-actions crossbow submit test-ubuntu-20.04-cpp-17 |
Revision: 21dd818 Submitted crossbow builds: ursacomputing/crossbow @ actions-1019
|
Also adding a minimal docker based build.. Closes apache#11474 from kszucs/abseil-include-dir Authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Also adding a minimal docker based build..