-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-14844: [R] Implement decimal256() #11898
Conversation
…`scale` are size 1
…ased on precision + docs
It looks like the CI workflows fail for 2 reasons:
@romainfrancois @jonkeane Any thoughts on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks for this + all of the Jiras that you created in the process!
Benchmark runs are scheduled for baseline = 281dee5 and contender = cfcce5a. cfcce5a is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
@jonkeane & @romainfrancois this is the 2nd attempt at implementing `decimal256()`. First one is apache#11805 Closes apache#11898 from dragosmg/ARROW-14844_decimal256_take2 Lead-authored-by: Dragos Moldovan-Grünfeld <dragos.mold@gmail.com> Co-authored-by: Dragoș Moldovan-Grünfeld <dragos.mold@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
Follow on to apache#11898 Closes apache#12005 from jonkeane/decimal-cleanup Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
@jonkeane & @romainfrancois this is the 2nd attempt at implementing
decimal256()
. First one is #11805