-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-15433: [Doc] Fix warnings when building #12242
Conversation
This fixes a number of warnings emitted when building the Sphinx docs.
@@ -46,7 +46,7 @@ class ExecContext; | |||
class ARROW_EXPORT ScalarAggregateOptions : public FunctionOptions { | |||
public: | |||
explicit ScalarAggregateOptions(bool skip_nulls = true, uint32_t min_count = 1); | |||
constexpr static char const kTypeName[] = "ScalarAggregateOptions"; | |||
static constexpr char const kTypeName[] = "ScalarAggregateOptions"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working around a slightly silly parsing bug: breathe-doc/breathe#787
@lidavidm What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine, though it would be nice to get it fixed upstream eventually.
Benchmark runs are scheduled for baseline = 9fb6def and contender = 231d0a6. 231d0a6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
This fixes a number of warnings emitted when building the Sphinx docs. Closes apache#12242 from pitrou/ARROW-15433-doc-warnings Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
This fixes a number of warnings emitted when building the Sphinx docs.