Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-15433: [Doc] Fix warnings when building #12242

Closed
wants to merge 1 commit into from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Jan 24, 2022

This fixes a number of warnings emitted when building the Sphinx docs.

This fixes a number of warnings emitted when building the Sphinx docs.
@github-actions
Copy link

@@ -46,7 +46,7 @@ class ExecContext;
class ARROW_EXPORT ScalarAggregateOptions : public FunctionOptions {
public:
explicit ScalarAggregateOptions(bool skip_nulls = true, uint32_t min_count = 1);
constexpr static char const kTypeName[] = "ScalarAggregateOptions";
static constexpr char const kTypeName[] = "ScalarAggregateOptions";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working around a slightly silly parsing bug: breathe-doc/breathe#787

@lidavidm What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine, though it would be nice to get it fixed upstream eventually.

@pitrou pitrou closed this in 231d0a6 Jan 25, 2022
@pitrou pitrou deleted the ARROW-15433-doc-warnings branch January 25, 2022 09:24
@ursabot
Copy link

ursabot commented Jan 25, 2022

Benchmark runs are scheduled for baseline = 9fb6def and contender = 231d0a6. 231d0a6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.45% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.22% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

pitrou added a commit to pitrou/arrow that referenced this pull request Jan 25, 2022
This fixes a number of warnings emitted when building the Sphinx docs.

Closes apache#12242 from pitrou/ARROW-15433-doc-warnings

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants