-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-15870: [Python] Start to raise deprecation warnings for use_legacy_dataset=True in parquet.read_table #12584
Conversation
…acy_dataset=True in parquet.read_table
@github-actions crossbow submit -g integration |
Revision: 78ff0a5 Submitted crossbow builds: ursacomputing/crossbow @ actions-1730 |
"Passing 'use_legacy_dataset=True' to get the legacy behaviour is " | ||
"deprecated as of pyarrow 8.0.0, and the legacy implementation will " | ||
"be removed in a future version.", | ||
DeprecationWarning, stacklevel=2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to use DeprecationWarning or FutureWarning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably directly raise a FutureWarning, but all the others here are still raising DeprecationWarnings. Will do a separate PR to change those all from deprecation to future warning.
Benchmark runs are scheduled for baseline = 2e314cb and contender = 3bf0617. 3bf0617 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Currently, users can still specify
use_legacy_dataset=True
explicitly to get the old implementation/behaviour. But if we want to remove that implementation at some point (ARROW-15868), we should start deprecating that option, to futher nudge people to the new implementation.