Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-15960: [C++] Fix crash on adaptive int builder edge cases #12690

Closed
wants to merge 1 commit into from
Closed

ARROW-15960: [C++] Fix crash on adaptive int builder edge cases #12690

wants to merge 1 commit into from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Mar 22, 2022

AdaptiveIntBuilder (and AdaptiveUIntBuilder) would crash when asked to append 0 nulls to a 0-length builder.

Also fixes the following PyArrow crash:

pa.array([None], pa.list_(pa.dictionary(pa.int32(), pa.string()), 0))

@pitrou
ARROW-15960: [C++] Fix crash on adaptive int builder edge cases
b6dd44a 
AdaptiveIntBuilder (and AdaptiveUIntBuilder) would crash when asked to append 0 nulls to a 0-length builder.

Also fixes the following PyArrow crash:
```python
pa.array([None], pa.list_(pa.dictionary(pa.int32(), pa.string()), 0))
```
@pitrou
Copy link
Member Author

pitrou commented Mar 22, 2022

@github-actions crossbow submit test-conda-python-3.8-hypothesis

jorisvandenbossche
jorisvandenbossche approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-15960

@github-actions
Copy link

Revision: b6dd44a

Submitted crossbow builds: ursacomputing/crossbow @ actions-1786

Task Status
test-conda-python-3.8-hypothesis Github Actions

@pitrou
Copy link
Member Author

pitrou commented Mar 22, 2022

Crossbow job running here:
https://github.com/ursacomputing/crossbow/runs/5648003625?check_suite_focus=true

@pitrou pitrou closed this in ad2fb74 Mar 22, 2022
@pitrou pitrou deleted the ARROW-15960-adaptive-crash branch March 22, 2022 18:00
@ursabot
Copy link

ursabot commented Mar 22, 2022 •
edited
Loading

Benchmark runs are scheduled for baseline = 2aeddad and contender = ad2fb74. ad2fb74 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.13% ⬆️0.04%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.38% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Component: C++ Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pitrou @ursabot @jorisvandenbossche