Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17003: [Java][Docs] Document arrow-jdbc adapter #13543

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

lidavidm
Copy link
Member

@lidavidm lidavidm commented Jul 7, 2022

Add a basic documentation page for the arrow-jdbc adapter.

I would also like to add a Cookbook page, and then cross-link the two pages, as a follow-up.

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@lidavidm
Copy link
Member Author

lidavidm commented Jul 7, 2022

CC @toddfarmer

@lidavidm
Copy link
Member Author

lidavidm commented Jul 7, 2022

Preview

image


The JDBC type can be explicitly specified, which is useful since JDBC
drivers can give spurious type information. For example, the Postgres
driver has been observed to use Decimal types with scale and precision
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to say anything about the behavior in the event of precision/scale mismatches? Specifically, different precision is allowed when the target precision is greater than the source. Scale must match exactly, unless an explicit RoundingMode is defined.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks. I'll clarify the docs when I rebase this on top of #13358

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a note to the Decimal type in the type mapping table below.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lidavidm lidavidm merged commit f1737f9 into apache:master Jul 13, 2022
@lidavidm lidavidm deleted the arrow-17003 branch July 13, 2022 12:01
@ursabot
Copy link

ursabot commented Jul 13, 2022

Benchmark runs are scheduled for baseline = 8608e19 and contender = f1737f9. f1737f9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.48% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.43% ⬆️0.07%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] f1737f93 ec2-t3-xlarge-us-east-2
[Finished] f1737f93 test-mac-arm
[Failed] f1737f93 ursa-i9-9960x
[Finished] f1737f93 ursa-thinkcentre-m75q
[Finished] 8608e193 ec2-t3-xlarge-us-east-2
[Finished] 8608e193 test-mac-arm
[Failed] 8608e193 ursa-i9-9960x
[Finished] 8608e193 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants