-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17003: [Java][Docs] Document arrow-jdbc adapter #13543
Conversation
|
CC @toddfarmer |
|
||
The JDBC type can be explicitly specified, which is useful since JDBC | ||
drivers can give spurious type information. For example, the Postgres | ||
driver has been observed to use Decimal types with scale and precision |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to say anything about the behavior in the event of precision/scale mismatches? Specifically, different precision is allowed when the target precision is greater than the source. Scale must match exactly, unless an explicit RoundingMode is defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, thanks. I'll clarify the docs when I rebase this on top of #13358
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a note to the Decimal type in the type mapping table below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Benchmark runs are scheduled for baseline = 8608e19 and contender = f1737f9. f1737f9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Add a basic documentation page for the arrow-jdbc adapter.
I would also like to add a Cookbook page, and then cross-link the two pages, as a follow-up.