ARROW-17433: [CI][C++] Use Visual Studio 2019 on AppVeyor #13903
Conversation
|
|
|
@pitrou Can we drop support for Visual Studio 2017? Visual Studio 2017 reached EOL at 2022-04-12: https://docs.microsoft.com/en-us/lifecycle/products/visual-studio-2017
If we can drop support for Visual Studio 2017, we can fix this problem. This problem is caused by the change boostorg/process#250 (comment) in Boost 1.80. Our build configuration on AppVeyor marks a warning as an error. With Boost 1.80, a warning in Boost causes the CI failure. We can solve this by marking Boost as an external (header) library. We can use CMake 3.22 https://cmake.org/cmake/help/latest/release/3.22.html added support for
But it requires Visual Studio 2019 or later because the If we can drop support for Visual Studio 2017, we can remove all CI jobs on AppVeyor because GitHub Actions provides Visual Studio 2019 or later. |
|
@kou This would probably warn on later MSVC versions also. |
|
As for not supporting VS2017, I think this is better asked on the ML. |
You mean that warnings from Boost? If so, they aren't reported with
OK. I'll send an e-mail. |
|
@kou Is the AppVeyor failure expected here? |
|
No. It's unexpected. I just tried to use Visual Studio 2019 on AppVeyer but it shows that we need to update our AppVeyor related scripts. So I stopped the work. And I found that we don't need CMake changes in this pull request to mark Boost as an external library. CMake marks |
|
@kou What is needed to move this forward? Ideally we'd like to unblock the AppVeyor CI. |
|
I'm waiting for comments from others on the mailing list thread. I think that we can remove the "JOB=Building_Debug, GENERATOR=Ninja" on AppVeyor job because the "AMD64 Windows 2019 C++17" on GitHub Actions job almost covers the case. |
It may be nice to keep a job on AppVeyor because we have long queues on GHA already. |
|
Hmm, I think that maintaining AppVeyor related scripts is high cost for us... but OK. I'll keep a job on AppVeyor. BTW, do you agree with removing the "JOB=Building_Debug, GENERATOR=Ninja" job? |
|
Sounds ok (even though the GHA build is much slower). |
kou
force-pushed
the
cpp-boost-system
branch
3 times, most recently
from
bbaeaa0
to
fc13e77
Compare
kou
force-pushed
the
cpp-boost-system
branch
2 times, most recently
from
a601656
to
8a7b340
Compare
kou
force-pushed
the
cpp-boost-system
branch
3 times, most recently
from
3b9a26b
to
59dec29
Compare
kou
changed the title
kou
force-pushed
the
cpp-boost-system
branch
3 times, most recently
from
da16a5f
to
4817b3d
Compare
|
@pitrou Could you fix the following build error? (You can push to this branch.) https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/44560863 I don't have Conda + Windows environment. So fixing this is difficult to me... Note: |
|
Hmm, I fixed the AppVeyor issue but there are unrelated |
|
It looks like a very old revision of the |
pitrou
force-pushed
the
cpp-boost-system
branch
from
494d56d
to
366d557
Compare
|
Rebased. |
|
Looks like CI is fixed. I'll let you proceed as you prefer @kou |
It seems that #13781 changed the |
We can use /external:I for Boost to suppress warnings from Boost with Visual Studio 2019 or later.
|
+1 |
|
Benchmark runs are scheduled for baseline = 04d2403 and contender = 897c186. 897c186 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
We can use /external:I for Boost to suppress warnings from Boost with Visual Studio 2019 or later. Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
We can use /external:I for Boost to suppress warnings from Boost with Visual Studio 2019 or later. Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
We can use /external:I for Boost to suppress warnings from Boost with Visual Studio 2019 or later. Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
We can use /external:I for Boost to suppress warnings from Boost
with Visual Studio 2019 or later.