Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17406: [C++] Failing to build the C++ Lib with tests #13869

Closed
wants to merge 3 commits into from

Conversation

kshitij12345
Copy link
Contributor

@kshitij12345 kshitij12345 commented Aug 13, 2022

Ref: https://issues.apache.org/jira/browse/ARROW-17406

Pin boost-cpp to a version which doesn't raise warning.

@kshitij12345 kshitij12345 marked this pull request as ready for review August 13, 2022 09:16
@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has no components in JIRA, make sure you assign one.

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@kou
Copy link
Member

kou commented Aug 13, 2022

We can use C++14 by specifying -DCMAKE_CXX_STANDARD=14.

@kshitij12345
Copy link
Contributor Author

@kou Do other parts of the library support c++14?
(Also are you suggesting to add this flag to the build snippet on the webpage that walks through the build process?)

@kou
Copy link
Member

kou commented Aug 13, 2022

Yes. We have CI jobs for C++14 and C++17.

If our documents miss it, could you update our documents?

@kshitij12345
Copy link
Contributor Author

Sure. Will look into that. Thanks @kou !

@pitrou
Copy link
Member

pitrou commented Aug 16, 2022

@kou Can we get this merged quickly to resolve CI failures?

@kou
Copy link
Member

kou commented Aug 16, 2022

Which CI failures are you thinking? There are many CI failures for now (oh...) but it seems that there are no CI failures related to this.

@pitrou
Copy link
Member

pitrou commented Aug 16, 2022

Sorry, I mean that merging this PR allows to fix AppVeyor, so we should do it quickly.

@kou
Copy link
Member

kou commented Aug 16, 2022

Ah, I see. But this is not a real fix. This is just a workaround.

I'll take a look at the CI failure tomorrow. Please wait for a while. If you can't wait, you can merge this.

@pitrou
Copy link
Member

pitrou commented Aug 16, 2022

Unblocking AppVeyor would be nice. As for the real fix, there is now some hope that we move to C++17 soon.

@kshitij12345
Copy link
Contributor Author

kshitij12345 commented Aug 16, 2022

Besides updating the doc, nothing actionable for me right? Thanks :)

cc: @pitrou @kou

@kou
Copy link
Member

kou commented Aug 17, 2022

Continuous discussion about AppVeyor failure: #13903

(I think that we can fix the AppVeyor failure by removing CI jobs on AppVeyor instead of merging this change.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants