Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17476: [Release][Packaging] Make binary uploader reusable from datafusion-c #13923

Merged
merged 1 commit into from
Aug 21, 2022
Merged

ARROW-17476: [Release][Packaging] Make binary uploader reusable from datafusion-c #13923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dev/release/05-binary-upload.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,9 @@ docker_run \
APT_TARGETS=$(IFS=,; echo "${apt_targets[*]}") \
ARTIFACTORY_API_KEY="${ARTIFACTORY_API_KEY}" \
ARTIFACTS_DIR="${tmp_dir}/artifacts" \
DEB_PACKAGE_NAME=${DEB_PACKAGE_NAME:-} \
DRY_RUN=${DRY_RUN:-no} \
GPG_KEY_ID="${GPG_KEY_ID}" \
RC=${rc} \
STAGING=${STAGING:-no} \
VERSION=${version} \
Expand Down
13 changes: 8 additions & 5 deletions dev/release/binary-task.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ def close

def request(method, headers, url, body: nil, &block)
request = build_request(method, url, headers, body: body)
if ENV["DRY_RUN"]
if ENV["DRY_RUN"] == "yes"
case request
when Net::HTTP::Get, Net::HTTP::Head
else
Expand Down Expand Up @@ -1302,10 +1302,13 @@ def define_apt_rc_tasks
Dir.glob("#{source_dir_prefix}*/**/*") do |path|
next if File.directory?(path)
base_name = File.basename(path)
if base_name.start_with?("apache-arrow-apt-source")
package_name = "apache-arrow-apt-source"
else
package_name = "apache-arrow"
package_name = ENV["DEB_PACKAGE_NAME"]
if package_name.nil? or package_name.empty?
if base_name.start_with?("apache-arrow-apt-source")
package_name = "apache-arrow-apt-source"
else
package_name = "apache-arrow"
end
end
destination_path = [
pool_dir,
Expand Down