Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-12724: [C++][Docs] Add documentation for authoring compute kernels #13933

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

drin
Copy link
Contributor

@drin drin commented Aug 20, 2022

The goal of this PR is to update the existing documentation for authoring compute kernels.

This PR will primarily reformat the documentation from markdown into reStructured text and updated descriptions. In some cases, I will try to reference a cookbook.

This is a new PR against apache/master, created as a rebase of the original PR (#10296) on top of apache/master as of 2022/08/20.

@github-actions
Copy link

@drin drin changed the title ARROW-12724: [C++] Add documentation for authoring compute kernels ARROW-12724: [C++][Docs] Add documentation for authoring compute kernels Aug 20, 2022
@drin
Copy link
Contributor Author

drin commented Aug 20, 2022

Note that I plan on using a cookbook (apache/arrow-cookbook#227) to address most snippets and examples in the future.

@rok
Copy link
Member

rok commented Aug 30, 2022

@github-actions crossbow submit preview-docs

@rok
Copy link
Member

rok commented Aug 30, 2022

https://crossbow.voltrondata.com/pr_docs/13933/ once docs are built.

@github-actions
Copy link

Unable to match any tasks for `preview-docs`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2955385922

@rok
Copy link
Member

rok commented Aug 30, 2022

Unable to match any tasks for `preview-docs`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2955385922

@drin sorry for the spam. preview-docs will run if you rebase.

edponce and others added 5 commits August 30, 2022 15:11
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
The "authoring compute kernels" docs was previously written in markdown.
This commit begins the process of changing the format to reST. There are
also some changes to make the organization and descriptions a bit more
clear and/or concise.
With the exception of some URLs which are still in markdown, this commit
addresses most comments left on the old PR. Most long lines were
wrapped, most prose suggestions were taken, code format styles were
changed from markdown to restructuredText.

There was some discussion in certain areas that have not yet been
addressed, but many of those will be addressed as I coalesce code
snippets and descriptions with the cookbook.
To make the documentation a bit cleaner, I am trying to split the
portions that explain the basic terminology and concepts of the compute
layer into a separate document from the portions that try to describe
code organization and best practices
@drin
Copy link
Contributor Author

drin commented Aug 30, 2022

rebased for that sweet doc preview feature

@rok
Copy link
Member

rok commented Aug 30, 2022

@github-actions crossbow submit preview-docs

@github-actions
Copy link

Revision: a0b0bc8

Submitted crossbow builds: ursacomputing/crossbow @ actions-53411d621c

Task Status
preview-docs Github Actions

@drin
Copy link
Contributor Author

drin commented Aug 30, 2022

I am still restructuring docs so this will need some iterations before final review, but it'll be cool to get initial feedback if the preview works

@rok
Copy link
Member

rok commented Aug 30, 2022

Indeed. You'll need to re-run for each preview.

@rok
Copy link
Member

rok commented Aug 31, 2022

cpp/developers/author_compute_fn.html

@drin
Copy link
Contributor Author

drin commented Aug 31, 2022

This page is still a work in progress, but it's where I am thinking of putting some higher level overview of "the compute layer" (what are compute functions, what are function kinds, etc.) so that the author_compute_fn.html doc can be a bit leaner and more to the point.

cpp/concepts/compute.html

@drin
Copy link
Contributor Author

drin commented Mar 14, 2023

Sorry for orphan-ing this for so long. I would like to get back to this towards the end of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants