Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: [R] Use a more future-proof test of str_like availability #13955

Closed
wants to merge 1 commit into from
Closed

MINOR: [R] Use a more future-proof test of str_like availability #13955

wants to merge 1 commit into from

Conversation

MichaelChirico
Copy link
Contributor

No description provided.

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@MichaelChirico MichaelChirico changed the title use a more future-proof test of str_like availability MINOR: [R] Use a more future-proof test of str_like availability Aug 24, 2022
thisisnic
thisisnic approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures unrelated to this change.
Nice solution there, thanks!

@thisisnic thisisnic closed this in 854283d Aug 31, 2022
anjakefala pushed a commit to anjakefala/arrow that referenced this pull request Aug 31, 2022
@MichaelChirico @anjakefala
MINOR: [R] Use a more future-proof test of str_like availability
caee09c 
Closes apache#13955 from MichaelChirico/patch-1

Authored-by: Michael Chirico <chiricom@google.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@assignUser assignUser mentioned this pull request Sep 7, 2022
Merged
nealrichardson added a commit to nealrichardson/arrow that referenced this pull request Sep 9, 2022
@nealrichardson
Pull in apache#13955 to work around str_like CRAN failure
df1068a
zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@MichaelChirico @zagto
MINOR: [R] Use a more future-proof test of str_like availability
6d773e5 
Closes apache#13955 from MichaelChirico/patch-1

Authored-by: Michael Chirico <chiricom@google.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@MichaelChirico @fatemehp
MINOR: [R] Use a more future-proof test of str_like availability
4364056 
Closes apache#13955 from MichaelChirico/patch-1

Authored-by: Michael Chirico <chiricom@google.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnic thisisnic thisisnic approved these changes

Assignees
No one assigned
Labels
Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelChirico @thisisnic