ARROW-17728: [C++][Gandiva] Accept LLVM 15.0

[js8544]

No description provided.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-17728

[github-actions]

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

[js8544]

There is another problem now: LLVM 15 adds dependency on zstd. It looks for target zstd::libzstd_shared, but arrow prefers zstd::libzstd. Let me try to turn off LLVM_ENABLE_ZSTD and see if it works.

[kou]

It seems that the Zstd's official CMake package uses zstd::libzstd_shared and zstd::libzstd_static.
So our CMake configurations should follow it. (And our Findzstd.cmake should support the Zstd's official CMake package too.)

I'll push a change for it to this branch later. Please wait for a while...

[pitrou]

There is another problem now: LLVM 15 adds dependency on zstd

Is it a mandatory dependency? zstd shouldn't be required to write a JIT...

[js8544]

There is another problem now: LLVM 15 adds dependency on zstd

Is it a mandatory dependency? zstd shouldn't be required to write a JIT...

The dependency can be avoided by turning LLVM_ENABLE_ZSTD off. But I'm a CMake newbie and not sure how to do it properly...

[pitrou]

Most probably, we must also accomodate for the fact that pre-built binary packages for LLVM probably have zstd enabled anyway.

[kou]

It seems that Gandiva with LLVM 15 have problems at least on MinGW.
But I'm not sure it's caused only on MinGW or can be caused on other platforms.
It's difficult to debug this on MinGW. So I propose that we merge this by disabling Gandiva related tests or Gandiva support only on MinGW for now. We can fix the problem when other platforms provide LLVM 15 and the same problem is occurred on these platforms.

[pitrou]

It's difficult to debug this on MinGW. So I propose that we merge this by disabling Gandiva related tests or Gandiva support only on MinGW for now. We can fix the problem when other platforms provide LLVM 15 and the same problem is occurred on these platforms.

That is fine with me.

[kou]

+1

We can merge this after we can confirm new CI failures aren't increased with this.

[kou]

"R / rhub/debian-gcc-devel:latest" is failed:

https://github.com/apache/arrow/actions/runs/3063524875/jobs/4951928558#step:5:27585

══ Failed tests ════════════════════════════════════════════════════════════════
── Error (test-duckdb.R:212:3): Joining, auto-cleanup enabled ──────────────────
Error: rapi_execute: Failed to run query
Error: Invalid Error: std::exception
Backtrace:
    ▆
 1. ├─DBI::dbGetQuery(...) at test-duckdb.R:212:2
 2. └─DBI::dbGetQuery(...)
 3.   └─DBI (local) .local(conn, statement, ...)
 4.     ├─DBI::dbSendQuery(conn, statement, ...)
 5.     └─duckdb::dbSendQuery(conn, statement, ...)
 6.       └─duckdb (local) .local(conn, statement, ...)
 7.         └─duckdb:::duckdb_result(...)
 8.           └─duckdb:::duckdb_execute(res)
 9.             └─duckdb:::rapi_execute(...)

[ FAIL 1 | WARN 0 | SKIP 28 | PASS 8467 ]

("AMD64 Ubuntu 20.04 R 4.2 Force-Tests true" has the same failure.)

But this will be solved by #14149. So I merge this.

[ursabot]

Benchmark runs are scheduled for baseline = 6bc2e01 and contender = 9131724. 9131724 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.2% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.28% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 9131724e ec2-t3-xlarge-us-east-2
[Failed] 9131724e test-mac-arm
[Failed] 9131724e ursa-i9-9960x
[Finished] 9131724e ursa-thinkcentre-m75q
[Finished] 6bc2e010 ec2-t3-xlarge-us-east-2
[Failed] 6bc2e010 test-mac-arm
[Failed] 6bc2e010 ursa-i9-9960x
[Finished] 6bc2e010 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

[ursabot]

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm
ursa-i9-9960x