-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17643: [R] Latest duckdb release is causing test failure #14149
Conversation
|
Benchmark runs are scheduled for baseline = b48d228 and contender = 6926672. 6926672 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
Is this actually fixed upstream? I see a build using DuckDB 0.5.1 here and it has the error: |
It looks like no! t I made ARROW-17809 and will look into it today and tomorrow. |
…e#14149) apache#14065 experimented with ways to solve this from Arrow's end; however, the fix in duckdb/duckdb#4712 is probably more robust. Even if that fix doesn't make it in to the next DuckDB release, when that happens this test will start failing again in case we/I forget to check. Authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
…e#14149) apache#14065 experimented with ways to solve this from Arrow's end; however, the fix in duckdb/duckdb#4712 is probably more robust. Even if that fix doesn't make it in to the next DuckDB release, when that happens this test will start failing again in case we/I forget to check. Authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
#14065 experimented with ways to solve this from Arrow's end; however, the fix in duckdb/duckdb#4712 is probably more robust. Even if that fix doesn't make it in to the next DuckDB release, when that happens this test will start failing again in case we/I forget to check.