Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17643: [R] Latest duckdb release is causing test failure #14149

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

paleolimbot
Copy link
Member

#14065 experimented with ways to solve this from Arrow's end; however, the fix in duckdb/duckdb#4712 is probably more robust. Even if that fix doesn't make it in to the next DuckDB release, when that happens this test will start failing again in case we/I forget to check.

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@nealrichardson nealrichardson merged commit 6926672 into apache:master Sep 16, 2022
@paleolimbot paleolimbot deleted the r-duckdb2 branch September 16, 2022 14:23
@ursabot
Copy link

ursabot commented Sep 17, 2022

Benchmark runs are scheduled for baseline = b48d228 and contender = 6926672. 6926672 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.27% ⬆️0.03%] test-mac-arm
[Failed ⬇️0.28% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.14% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 69266721 ec2-t3-xlarge-us-east-2
[Finished] 69266721 test-mac-arm
[Failed] 69266721 ursa-i9-9960x
[Finished] 69266721 ursa-thinkcentre-m75q
[Finished] b48d2287 ec2-t3-xlarge-us-east-2
[Finished] b48d2287 test-mac-arm
[Failed] b48d2287 ursa-i9-9960x
[Finished] b48d2287 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Sep 17, 2022

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm
ursa-i9-9960x

@pitrou
Copy link
Member

pitrou commented Sep 21, 2022

Is this actually fixed upstream? I see a build using DuckDB 0.5.1 here and it has the error:
https://github.com/apache/arrow/actions/runs/3095675589/jobs/5010340520#step:7:31839

@paleolimbot
Copy link
Member Author

It looks like no! t I made ARROW-17809 and will look into it today and tomorrow.

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
…e#14149)

apache#14065 experimented with ways to solve this from Arrow's end; however, the fix in duckdb/duckdb#4712 is probably more robust. Even if that fix doesn't make it in to the next DuckDB release, when that happens this test will start failing again in case we/I forget to check.

Authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
…e#14149)

apache#14065 experimented with ways to solve this from Arrow's end; however, the fix in duckdb/duckdb#4712 is probably more robust. Even if that fix doesn't make it in to the next DuckDB release, when that happens this test will start failing again in case we/I forget to check.

Authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants