ARROW-299: Use absolute namespace in macros #142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I8e58fb49c24737d301d8bc3718a269be1622c215
|
+1 |
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 2, 2018
Working version but still some minor stuff to clean up (but I'd be happy for comments). Had to change the Encoder interface to make it work with dictionary encoding. Also dictionary encoded RowGroups are currently limited to a single DataPage. Author: Uwe L. Korn <uwelk@xhochy.com> Closes apache#142 from xhochy/parquet-666 and squashes the following commits: 95e4753 [Uwe L. Korn] Fix PARQUET-591 and get make more use of WriterProperties 8f5b2bb [Uwe L. Korn] Comment out unused private variable 32adfd9 [Uwe L. Korn] Remove compression code duplication 6804e2a [Uwe L. Korn] Remove deprecated TODO 0d58ef2 [Uwe L. Korn] Pass DictionaryPage objects to the page writer 95fdccd [Uwe L. Korn] Get rid of temporarly created struct cce17f9 [Uwe L. Korn] Store serialised pages 2841494 [Uwe L. Korn] Remove unsigned/signed comparison 7ce98ca [Uwe L. Korn] Store pages in RAM until the end of the column 17533bf [Uwe L. Korn] Remove code duplication a3b4043 [Uwe L. Korn] PARQUET-666: Add support for writing dictionaries
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 4, 2018
Working version but still some minor stuff to clean up (but I'd be happy for comments). Had to change the Encoder interface to make it work with dictionary encoding. Also dictionary encoded RowGroups are currently limited to a single DataPage. Author: Uwe L. Korn <uwelk@xhochy.com> Closes apache#142 from xhochy/parquet-666 and squashes the following commits: 95e4753 [Uwe L. Korn] Fix PARQUET-591 and get make more use of WriterProperties 8f5b2bb [Uwe L. Korn] Comment out unused private variable 32adfd9 [Uwe L. Korn] Remove compression code duplication 6804e2a [Uwe L. Korn] Remove deprecated TODO 0d58ef2 [Uwe L. Korn] Pass DictionaryPage objects to the page writer 95fdccd [Uwe L. Korn] Get rid of temporarly created struct cce17f9 [Uwe L. Korn] Store serialised pages 2841494 [Uwe L. Korn] Remove unsigned/signed comparison 7ce98ca [Uwe L. Korn] Store pages in RAM until the end of the column 17533bf [Uwe L. Korn] Remove code duplication a3b4043 [Uwe L. Korn] PARQUET-666: Add support for writing dictionaries Change-Id: I72a4dfcd9f17159d338ed78f9bf20ff6106dcbf2
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 6, 2018
Working version but still some minor stuff to clean up (but I'd be happy for comments). Had to change the Encoder interface to make it work with dictionary encoding. Also dictionary encoded RowGroups are currently limited to a single DataPage. Author: Uwe L. Korn <uwelk@xhochy.com> Closes apache#142 from xhochy/parquet-666 and squashes the following commits: 95e4753 [Uwe L. Korn] Fix PARQUET-591 and get make more use of WriterProperties 8f5b2bb [Uwe L. Korn] Comment out unused private variable 32adfd9 [Uwe L. Korn] Remove compression code duplication 6804e2a [Uwe L. Korn] Remove deprecated TODO 0d58ef2 [Uwe L. Korn] Pass DictionaryPage objects to the page writer 95fdccd [Uwe L. Korn] Get rid of temporarly created struct cce17f9 [Uwe L. Korn] Store serialised pages 2841494 [Uwe L. Korn] Remove unsigned/signed comparison 7ce98ca [Uwe L. Korn] Store pages in RAM until the end of the column 17533bf [Uwe L. Korn] Remove code duplication a3b4043 [Uwe L. Korn] PARQUET-666: Add support for writing dictionaries Change-Id: I72a4dfcd9f17159d338ed78f9bf20ff6106dcbf2
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 7, 2018
Working version but still some minor stuff to clean up (but I'd be happy for comments). Had to change the Encoder interface to make it work with dictionary encoding. Also dictionary encoded RowGroups are currently limited to a single DataPage. Author: Uwe L. Korn <uwelk@xhochy.com> Closes apache#142 from xhochy/parquet-666 and squashes the following commits: 95e4753 [Uwe L. Korn] Fix PARQUET-591 and get make more use of WriterProperties 8f5b2bb [Uwe L. Korn] Comment out unused private variable 32adfd9 [Uwe L. Korn] Remove compression code duplication 6804e2a [Uwe L. Korn] Remove deprecated TODO 0d58ef2 [Uwe L. Korn] Pass DictionaryPage objects to the page writer 95fdccd [Uwe L. Korn] Get rid of temporarly created struct cce17f9 [Uwe L. Korn] Store serialised pages 2841494 [Uwe L. Korn] Remove unsigned/signed comparison 7ce98ca [Uwe L. Korn] Store pages in RAM until the end of the column 17533bf [Uwe L. Korn] Remove code duplication a3b4043 [Uwe L. Korn] PARQUET-666: Add support for writing dictionaries Change-Id: I72a4dfcd9f17159d338ed78f9bf20ff6106dcbf2
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
Working version but still some minor stuff to clean up (but I'd be happy for comments). Had to change the Encoder interface to make it work with dictionary encoding. Also dictionary encoded RowGroups are currently limited to a single DataPage. Author: Uwe L. Korn <uwelk@xhochy.com> Closes apache#142 from xhochy/parquet-666 and squashes the following commits: 95e4753 [Uwe L. Korn] Fix PARQUET-591 and get make more use of WriterProperties 8f5b2bb [Uwe L. Korn] Comment out unused private variable 32adfd9 [Uwe L. Korn] Remove compression code duplication 6804e2a [Uwe L. Korn] Remove deprecated TODO 0d58ef2 [Uwe L. Korn] Pass DictionaryPage objects to the page writer 95fdccd [Uwe L. Korn] Get rid of temporarly created struct cce17f9 [Uwe L. Korn] Store serialised pages 2841494 [Uwe L. Korn] Remove unsigned/signed comparison 7ce98ca [Uwe L. Korn] Store pages in RAM until the end of the column 17533bf [Uwe L. Korn] Remove code duplication a3b4043 [Uwe L. Korn] PARQUET-666: Add support for writing dictionaries Change-Id: I72a4dfcd9f17159d338ed78f9bf20ff6106dcbf2
zhouyuan
pushed a commit
to zhouyuan/arrow
that referenced
this pull request
Aug 19, 2022
* support REF in parse_url * consistent with spark * change comment * fix test failure * change the way get the query item * add missing code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.