-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17795: [C++][R] Add missing PKG_CONFIG_PATH to use system zstd #14202
Changes from all commits
bc9541a
b4256f6
e3cbf41
7adcb5b
2d78246
2a596cb
5653d0b
6c4c384
c04e0da
3cef9bf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -184,8 +184,8 @@ else | |
|
||
# Use pkg-config to do static linking of libarrow's dependencies | ||
if [ "$ARROW_DEPENDENCY_SOURCE" = "AUTO" ] || [ "$ARROW_DEPENDENCY_SOURCE" = "SYSTEM" ]; then | ||
PKG_LIBS="`PKG_CONFIG_PATH=${LIB_DIR}/pkgconfig pkg-config --libs-only-l --static --silence-errors ${PKG_CONFIG_NAME}`" | ||
PKG_LIBS="$PKG_LIBS `PKG_CONFIG_PATH=${LIB_DIR}/pkgconfig pkg-config --libs-only-other --static --silence-errors ${PKG_CONFIG_NAME}`" | ||
export PKG_CONFIG_PATH=${LIB_DIR}/pkgconfig${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}} | ||
PKG_LIBS="`pkg-config --libs --static --silence-errors ${PKG_CONFIG_NAME}`" | ||
Comment on lines
+187
to
+188
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These changes are not required for configure.win because we use the mysys stuff anyway right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't see |
||
fi | ||
|
||
# When using brew's openssl it is not bundled and it is not on the system | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove this before merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to keep this to debug a problem in the future.
This step is executed only when the above build step is failed. Is it accepted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 makes sense!