Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17934: [R] Use tempfile instead of working directory for dataset test #14315

Merged
merged 1 commit into from
Oct 4, 2022
Merged

ARROW-17934: [R] Use tempfile instead of working directory for dataset test #14315

merged 1 commit into from
Oct 4, 2022

Conversation

paleolimbot
Copy link
Member

In recent checkouts I get the folder tests/testthat/another_dataset leftover after running devtools::test(). This PR just uses a tempfile instead and cleans it up afterward!

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

https://issues.apache.org/jira/browse/ARROW-17934

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

thisisnic
thisisnic approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@paleolimbot paleolimbot merged commit 92820cb into apache:master Oct 4, 2022
@ursabot
Copy link

ursabot commented Oct 4, 2022

Benchmark runs are scheduled for baseline = f483340 and contender = 92820cb. 92820cb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.56% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.55% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.04% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 92820cbd ec2-t3-xlarge-us-east-2
[Failed] 92820cbd test-mac-arm
[Failed] 92820cbd ursa-i9-9960x
[Finished] 92820cbd ursa-thinkcentre-m75q
[Finished] f4833409 ec2-t3-xlarge-us-east-2
[Failed] f4833409 test-mac-arm
[Failed] f4833409 ursa-i9-9960x
[Finished] f4833409 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Oct 4, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

@paleolimbot paleolimbot deleted the another-dataset branch October 17, 2022 17:12
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@paleolimbot @fatemehp
ARROW-17934: [R] Use tempfile instead of working directory for datase…
6192b15 
…t test (apache#14315)

In recent checkouts I get the folder `tests/testthat/another_dataset` leftover after running devtools::test(). This PR just uses a tempfile instead and cleans it up afterward!

Authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnic thisisnic thisisnic approved these changes

Assignees
No one assigned
Labels
Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paleolimbot @ursabot @thisisnic