Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17099: [Python] pyarrow build does not support RELWITHDEBINFO build type #14324

Merged
merged 2 commits into from
Oct 6, 2022
Merged

ARROW-17099: [Python] pyarrow build does not support RELWITHDEBINFO build type #14324

merged 2 commits into from
Oct 6, 2022

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Oct 5, 2022

Add support for RelWithDebInfo in the PyArrow build process defined in setup.py.

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

https://issues.apache.org/jira/browse/ARROW-17099

pitrou
pitrou reviewed Oct 5, 2022
View reviewed changes
python/setup.py Show resolved Hide resolved
pitrou
pitrou approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you fix the lint failure?

@pitrou pitrou merged commit 287ede7 into apache:master Oct 6, 2022
@pitrou
Copy link
Member

pitrou commented Oct 6, 2022

Thanks @AlenkaF !

@AlenkaF AlenkaF deleted the ARROW-17099 branch October 6, 2022 06:50
@ursabot
Copy link

ursabot commented Oct 6, 2022

Benchmark runs are scheduled for baseline = 69249c3 and contender = 287ede7. 287ede7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] test-mac-arm
[Failed ⬇️3.01% ⬆️0.27%] ursa-i9-9960x
[Finished ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 287ede7b ec2-t3-xlarge-us-east-2
[Failed] 287ede7b test-mac-arm
[Failed] 287ede7b ursa-i9-9960x
[Finished] 287ede7b ursa-thinkcentre-m75q
[Finished] 69249c3c ec2-t3-xlarge-us-east-2
[Failed] 69249c3c test-mac-arm
[Failed] 69249c3c ursa-i9-9960x
[Finished] 69249c3c ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@AlenkaF @fatemehp
ARROW-17099: [Python] pyarrow build does not support RELWITHDEBINFO b…
5109e3d 
…uild type (apache#14324)

Add support for `RelWithDebInfo` in the PyArrow build process defined in `setup.py`.

Authored-by: Alenka Frim <frim.alenka@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@asfimport asfimport mentioned this pull request Oct 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlenkaF @pitrou @ursabot