Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17992: [CI][C++][Conda] Remove needless clangdev/llvmdev pinnings #14376

Merged
merged 3 commits into from
Oct 12, 2022

Conversation

kou
Copy link
Member

@kou kou commented Oct 11, 2022

We need clang 11 or later for Gandiva.

https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=37098&view=logs&j=4c86bc1b-1091-5192-4404-c74dfaad23e7&t=41795ef0-6501-5db4-3ad4-33c0cf085626&l=1001

[6/94] Generating decimal_ops.bc
FAILED: src/gandiva/precompiled/decimal_ops.bc
D:/bld/arrow-cpp-ext_1665469353844/work/cpp/build/src/gandiva/precompiled/decimal_ops.bc
cmd.exe /C "cd /D
D:\bld\arrow-cpp-ext_1665469353844\work\cpp\build\src\gandiva\precompiled
&& D:\bld\arrow-cpp-ext_1665469353844\_h_env\Library\bin\clang.exe
-std=c++17 -fms-compatibility -fms-compatibility-version=19.20
-DGANDIVA_IR -DNDEBUG -DARROW_STATIC -DGANDIVA_STATIC
-fno-use-cxa-atexit -emit-llvm -O3 -c
D:/bld/arrow-cpp-ext_1665469353844/work/cpp/src/gandiva/precompiled/decimal_ops.cc
-o
D:/bld/arrow-cpp-ext_1665469353844/work/cpp/build/src/gandiva/precompiled/decimal_ops.bc
-ID:/bld/arrow-cpp-ext_1665469353844/work/cpp/src
-ID:/bld/arrow-cpp-ext_1665469353844/work/cpp/build/src
-ID:/bld/arrow-cpp-ext_1665469353844/_h_env/Library/include"
In file included from
D:/bld/arrow-cpp-ext_1665469353844/work/cpp/src/gandiva/precompiled/decimal_ops.cc:20:
In file included from
D:/bld/arrow-cpp-ext_1665469353844/work/cpp/src\gandiva/precompiled/decimal_ops.h:20:
In file included from C:\Program Files (x86)\Microsoft Visual
Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\cstdint:9:
C:\Program Files (x86)\Microsoft Visual
Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\yvals_core.h:571:2:
error: STL1000: Unexpected compiler version, expected Clang 11.0.0
or newer.
#error STL1000: Unexpected compiler version, expected Clang 11.0.0 or newer.
 ^

This was added by me in #13892 but I can't remember why I pinned to 10...

We need clang 11 or later for Gandiva.

https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=37098&view=logs&j=4c86bc1b-1091-5192-4404-c74dfaad23e7&t=41795ef0-6501-5db4-3ad4-33c0cf085626&l=1001

    [6/94] Generating decimal_ops.bc
    FAILED: src/gandiva/precompiled/decimal_ops.bc
    D:/bld/arrow-cpp-ext_1665469353844/work/cpp/build/src/gandiva/precompiled/decimal_ops.bc
    cmd.exe /C "cd /D
    D:\bld\arrow-cpp-ext_1665469353844\work\cpp\build\src\gandiva\precompiled
    && D:\bld\arrow-cpp-ext_1665469353844\_h_env\Library\bin\clang.exe
    -std=c++17 -fms-compatibility -fms-compatibility-version=19.20
    -DGANDIVA_IR -DNDEBUG -DARROW_STATIC -DGANDIVA_STATIC
    -fno-use-cxa-atexit -emit-llvm -O3 -c
    D:/bld/arrow-cpp-ext_1665469353844/work/cpp/src/gandiva/precompiled/decimal_ops.cc
    -o
    D:/bld/arrow-cpp-ext_1665469353844/work/cpp/build/src/gandiva/precompiled/decimal_ops.bc
    -ID:/bld/arrow-cpp-ext_1665469353844/work/cpp/src
    -ID:/bld/arrow-cpp-ext_1665469353844/work/cpp/build/src
    -ID:/bld/arrow-cpp-ext_1665469353844/_h_env/Library/include"
    In file included from
    D:/bld/arrow-cpp-ext_1665469353844/work/cpp/src/gandiva/precompiled/decimal_ops.cc:20:
    In file included from
    D:/bld/arrow-cpp-ext_1665469353844/work/cpp/src\gandiva/precompiled/decimal_ops.h:20:
    In file included from C:\Program Files (x86)\Microsoft Visual
    Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\cstdint:9:
    C:\Program Files (x86)\Microsoft Visual
    Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\yvals_core.h:571:2:
    error: STL1000: Unexpected compiler version, expected Clang 11.0.0
    or newer.
    #error STL1000: Unexpected compiler version, expected Clang 11.0.0 or newer.
     ^

This was added by me in apache#13892 but I can't remember why I pinned to
10...
@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@kou

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@kou
Copy link
Member Author

kou commented Oct 11, 2022

@github-actions crossbow submit conda-win-*

@github-actions

This comment was marked as outdated.

@kou
Copy link
Member Author

kou commented Oct 12, 2022

@github-actions crossbow submit conda-win-*

@github-actions
Copy link

Revision: b758bf1

Submitted crossbow builds: ursacomputing/crossbow @ actions-79ea095ba1

Task Status
conda-win-vs2019-py310 Azure
conda-win-vs2019-py37-r40 Azure
conda-win-vs2019-py37-r41 Azure
conda-win-vs2019-py38 Azure
conda-win-vs2019-py39 Azure

@kou
Copy link
Member Author

kou commented Oct 12, 2022

+1

conda-win-vs2019-py37-r* failures are unrelated. I don't know why but someone sets -std=c++14:

https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=37178&view=logs&j=4c86bc1b-1091-5192-4404-c74dfaad23e7&t=ec99a26b-0264-5e86-36fb-9cfd0ca0f9f3&l=528

%SRC_DIR%>set "CXXFLAGS=-fvisibility-inlines-hidden -std=c++14 -fmessage-length=0 -march=k8 -mtune=haswell -ftree-vectorize -fstack-protector-strong -O2 -ffunction-sections -pipe -D_CRT_SECURE_NO_WARNINGS -D_MT -D_DLL -nostdlib -Xclang --dependent-lib=msvcrt -fuse-ld=lld -fno-aligned-allocation" 

We need to use C++17 or later.

@kou kou merged commit 2724150 into apache:master Oct 12, 2022
@kou kou deleted the ci-cpp-gandiva-conda-llvm branch October 12, 2022 03:29
@ursabot
Copy link

ursabot commented Oct 12, 2022

Benchmark runs are scheduled for baseline = cdd0fdf and contender = 2724150. 2724150 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️2.22% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.82% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 2724150e ec2-t3-xlarge-us-east-2
[Failed] 2724150e test-mac-arm
[Failed] 2724150e ursa-i9-9960x
[Finished] 2724150e ursa-thinkcentre-m75q
[Finished] cdd0fdf3 ec2-t3-xlarge-us-east-2
[Failed] cdd0fdf3 test-mac-arm
[Failed] cdd0fdf3 ursa-i9-9960x
[Finished] cdd0fdf3 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Oct 12, 2022

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants