Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17975: [C++] Create at-fork facility #14594

Merged
merged 5 commits into from
Nov 7, 2022
Merged

ARROW-17975: [C++] Create at-fork facility #14594

merged 5 commits into from
Nov 7, 2022

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Nov 5, 2022

Also migrate the ThreadPool class to use the new facility.

The util::GlobalForkSafeMutex facility is now unused, we may want to remove it in a later PR.

@github-actions
Copy link

github-actions bot commented Nov 5, 2022

https://issues.apache.org/jira/browse/ARROW-17975

@pitrou
Copy link
Member Author

pitrou commented Nov 5, 2022

@github-actions crossbow submit -g cpp

@github-actions
Copy link

github-actions bot commented Nov 5, 2022

Revision: 961a457

Submitted crossbow builds: ursacomputing/crossbow @ actions-21ee6e6b86

Task Status
test-alpine-linux-cpp Github Actions
test-build-cpp-fuzz Github Actions
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-cuda-cpp Github Actions
test-debian-10-cpp-amd64 Github Actions
test-debian-10-cpp-i386 Github Actions
test-debian-11-cpp-amd64 Github Actions
test-debian-11-cpp-i386 Github Actions
test-fedora-35-cpp Github Actions
test-ubuntu-18.04-cpp Github Actions
test-ubuntu-18.04-cpp-release Github Actions
test-ubuntu-18.04-cpp-static Github Actions
test-ubuntu-20.04-cpp Github Actions
test-ubuntu-20.04-cpp-20 Github Actions
test-ubuntu-20.04-cpp-bundled Github Actions
test-ubuntu-20.04-cpp-thread-sanitizer Github Actions
test-ubuntu-22.04-cpp Github Actions

@pitrou pitrou requested a review from lidavidm November 5, 2022 20:41
@pitrou pitrou merged commit 619b034 into apache:master Nov 7, 2022
@pitrou pitrou deleted the ARROW-17975-atfork branch November 7, 2022 17:19
@pitrou pitrou mentioned this pull request Nov 7, 2022
Merged
@westonpace
Copy link
Member

Thanks for doing this. Looks like a very useful utility and IIRC the atfork handlers should be a safer way of solving this problem too.

@pitrou
Copy link
Member Author

pitrou commented Nov 7, 2022

Yes, hopefully it should be more robust than the previous way of inspecting the current pid in random places...

@ursabot
Copy link

ursabot commented Nov 7, 2022

Benchmark runs are scheduled for baseline = 7f067f9 and contender = 619b034. 619b034 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️1.69% ⬆️2.1%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.16% ⬆️0.74%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 619b034b ec2-t3-xlarge-us-east-2
[Failed] 619b034b test-mac-arm
[Finished] 619b034b ursa-i9-9960x
[Finished] 619b034b ursa-thinkcentre-m75q
[Finished] 7f067f9a ec2-t3-xlarge-us-east-2
[Failed] 7f067f9a test-mac-arm
[Failed] 7f067f9a ursa-i9-9960x
[Finished] 7f067f9a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Nov 7, 2022
@pitrou @fatemehp
ARROW-17975: [C++] Create at-fork facility (apache#14594)
c61f2ec 
Also migrate the `ThreadPool` class to use the new facility.

The `util::GlobalForkSafeMutex` facility is now unused, we may want to remove it in a later PR.

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request Nov 8, 2022
@pitrou @vibhatha
ARROW-17975: [C++] Create at-fork facility (apache#14594)
5ef742a 
Also migrate the `ThreadPool` class to use the new facility.

The `util::GlobalForkSafeMutex` facility is now unused, we may want to remove it in a later PR.

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@asfimport asfimport mentioned this pull request Nov 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pitrou @westonpace @ursabot @lidavidm