-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-14745: [R] {rlang} dependency must be at least version 1.0.0 because of check_dots_empty #14744
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this!
We are currently migrating from JIRA to github issues so the messages are not up-to-date. Could you prepend the title with GH-<issue number>: [R]
Edited title |
Unfortunately, the upgraded version of rlang has different (better!) error messages, and so there are test failures on CI as our testthat snapshots need updating too. @daattali - would you mind either updating them, or allowing me to push to your fork and I'll make those updates myself? |
The "Allow edits by maintainers" box is checked, you should be able to edit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for flagging this up and submitting the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for flagging this up and submitting the PR!
Benchmark runs are scheduled for baseline = a594e38 and contender = fde7b93. fde7b93 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
The function rlang::check_dots_empty() is used in this package. That function only became available in rlang version 1.0.0, so that version should be specified as the minimum