Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-14745: [R] {rlang} dependency must be at least version 1.0.0 because of check_dots_empty #14744

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

daattali
Copy link
Contributor

The function rlang::check_dots_empty() is used in this package. That function only became available in rlang version 1.0.0, so that version should be specified as the minimum

@github-actions

This comment was marked as outdated.

Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

We are currently migrating from JIRA to github issues so the messages are not up-to-date. Could you prepend the title with GH-<issue number>: [R]

@daattali daattali changed the title {rlang} dependency must be at least version 1.0.0 because of check_dots_empty GH-14745: [R] {rlang} dependency must be at least version 1.0.0 because of check_dots_empty Nov 27, 2022
@daattali
Copy link
Contributor Author

Edited title

@assignUser assignUser added this to the 11.0.0 milestone Nov 27, 2022
@thisisnic
Copy link
Member

Unfortunately, the upgraded version of rlang has different (better!) error messages, and so there are test failures on CI as our testthat snapshots need updating too. @daattali - would you mind either updating them, or allowing me to push to your fork and I'll make those updates myself?

@daattali
Copy link
Contributor Author

The "Allow edits by maintainers" box is checked, you should be able to edit

Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for flagging this up and submitting the PR!

Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for flagging this up and submitting the PR!

@jorisvandenbossche jorisvandenbossche merged commit fde7b93 into apache:master Nov 29, 2022
@ursabot
Copy link

ursabot commented Nov 30, 2022

Benchmark runs are scheduled for baseline = a594e38 and contender = fde7b93. fde7b93 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.2% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.54% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.14% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] fde7b937 ec2-t3-xlarge-us-east-2
[Failed] fde7b937 test-mac-arm
[Finished] fde7b937 ursa-i9-9960x
[Finished] fde7b937 ursa-thinkcentre-m75q
[Finished] a594e38f ec2-t3-xlarge-us-east-2
[Finished] a594e38f test-mac-arm
[Finished] a594e38f ursa-i9-9960x
[Finished] a594e38f ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants