Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-14828: [CI][Conda] Sync with conda-forge, fix nightly jobs #14832

Merged
merged 25 commits into from
Dec 12, 2022

Conversation

h-vetinari
Copy link
Contributor

@h-vetinari h-vetinari commented Dec 4, 2022

Synching after conda-forge/arrow-cpp-feedstock#875, which does quite a lot of things, see this summary. I'm not keeping the commit history here, but it might be instructive to check the commits there to see why certain changes came about.

It also fixes the CI that was broken by a3ef64b (undoing the changes of #14102 in tasks.yml).

Finally, it adapts to conda making a long-planned switch w.r.t. to the format / extension of the artefacts it produces.

I'm very likely going to need some help (or at least pointers) for the R-stuff. CC @xhochy
(for context, I never got a response to conda-forge/r-arrow-feedstock#55, but I'll open a PR to build against libarrow 10).

Once this is done, I can open issues to tackle the tests that shouldn't be failing, resp. the segfaults on PPC resp. in conjunction with sparse.

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

⚠️ GitHub issue #14828 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

⚠️ GitHub issue #14828 has no components, please add labels for components.

@h-vetinari
Copy link
Contributor Author

I have a tentative PR for r-arrow, but it's going to need some more work: conda-forge/r-arrow-feedstock#58

@kou kou changed the title GH-14828: Fix Conda CI GH-14828: [CI][Conda] Fix nightly jobs Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

⚠️ GitHub issue #14828 has no components, please add labels for components.

@kou
Copy link
Member

kou commented Dec 5, 2022

@github-actions crossbow submit -g conda

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Revision: a123df8

Submitted crossbow builds: ursacomputing/crossbow @ actions-219630b6c6

Task Status
conda-clean Azure
conda-linux-gcc-openssl1.1.1-aarch64 Azure
conda-linux-gcc-openssl1.1.1-cpu Azure
conda-linux-gcc-openssl1.1.1-cuda Azure
conda-linux-gcc-openssl1.1.1-ppc64le Azure
conda-linux-gcc-openssl3-aarch64 Azure
conda-linux-gcc-openssl3-cpu Azure
conda-linux-gcc-openssl3-cuda Azure
conda-linux-gcc-openssl3-ppc64le Azure
conda-linux-gcc-py37-cpu-r40 Azure
conda-linux-gcc-py37-cpu-r41 Azure
conda-osx-arm64-clang-openssl1.1.1 Azure
conda-osx-arm64-clang-openssl3 Azure
conda-osx-clang-openssl1.1.1 Azure
conda-osx-clang-openssl3 Azure
conda-osx-clang-py37-r40 Azure
conda-osx-clang-py37-r41 Azure
conda-win-vs2019-openssl1.1.1 Azure
conda-win-vs2019-openssl1.1.1-cuda Azure
conda-win-vs2019-openssl3 Azure
conda-win-vs2019-openssl3-cuda Azure
conda-win-vs2019-py37-r40 Azure
conda-win-vs2019-py37-r41 Azure

@h-vetinari
Copy link
Contributor Author

h-vetinari commented Dec 5, 2022

OK, I think I cracked the r-issues in conda-forge/r-arrow-feedstock#58, and updated things correspondingly here.

Also:

  • avoid patch (line-ending issues when applying on windows), patch gcs_server fixture directly see 759e705
  • add r-jobs for linux-aarch64 & osx-arm64 (these were in fact broken by 8139cdd and need ${R_ARGS} to pass in cross-compilation)
  • homogenize naming of conda jobs, see 39587c3

compilers are redundant as they are fixed per platform
@h-vetinari
Copy link
Contributor Author

@github-actions crossbow submit -g conda

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Revision: 39587c3

Submitted crossbow builds: ursacomputing/crossbow @ actions-9d7ac78bae

Task Status
conda-clean Azure
conda-linux-aarch64-cpu-openssl1.1.1 Azure
conda-linux-aarch64-cpu-openssl3 Azure
conda-linux-aarch64-cpu-r41 Azure
conda-linux-aarch64-cpu-r42 Azure
conda-linux-ppc64le-cpu-openssl1.1.1 Azure
conda-linux-ppc64le-cpu-openssl3 Azure
conda-linux-x64-cpu-openssl1.1.1 Azure
conda-linux-x64-cpu-openssl3 Azure
conda-linux-x64-cpu-r41 Azure
conda-linux-x64-cpu-r42 Azure
conda-linux-x64-cuda-openssl1.1.1 Azure
conda-linux-x64-cuda-openssl3 Azure
conda-osx-arm64-cpu-r41 Azure
conda-osx-arm64-cpu-r42 Azure
conda-osx-arm64-openssl1.1.1 Azure
conda-osx-arm64-openssl3 Azure
conda-osx-x64-cpu-r41 Azure
conda-osx-x64-cpu-r42 Azure
conda-osx-x64-openssl1.1.1 Azure
conda-osx-x64-openssl3 Azure
conda-win-x64-cpu-openssl1.1.1 Azure
conda-win-x64-cpu-openssl3 Azure
conda-win-x64-cpu-r41 Azure
conda-win-x64-cuda-openssl1.1.1 Azure
conda-win-x64-cuda-openssl3 Azure

@h-vetinari
Copy link
Contributor Author

@github-actions crossbow submit -g conda

h-vetinari added a commit to h-vetinari/r-arrow-feedstock that referenced this pull request Dec 6, 2022
@h-vetinari
Copy link
Contributor Author

Any further help you would need from my side?

Ah one more thing, you could help with conda-forge/conda-forge-pinning-feedstock#3793, please.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the changes to the conda feedstock files are just adapted from upstream (as we would like them to be, without unnecessary changes on our side), I didn't review that part, but the changes to pyarrow itself look fine.

@jorisvandenbossche
Copy link
Member

Looking at the two remaining failures, one question though: the failures happen on a build with "-r41" suffix (conda-linux-aarch64-cpu-r41 and conda-win-x64-cpu-r41), but it are actually pyarrow test failures (not R arrow). But there is also a build for the same architecture with "-py3" suffix (which is also running the pyarrow tests). That seems a bit superfluous to run the python tests in each of the R builds as well?

@h-vetinari
Copy link
Contributor Author

h-vetinari commented Dec 7, 2022

But there is also a build for the same architecture with "-py3" suffix (which is also running the pyarrow tests). That seems a bit superfluous to run the python tests in each of the R builds as well?

That's unavoidable without some surgery or splitting the feedstocks into libarrow and pyarrow - R only needs the former, but both get built by the same recipe.

I can imagine trying to add a skip for the python bits based on some environment variable (e.g. if we detect R_CONFIG), but so far I've left the feedstock recipes untouched as much as possible (this is also how things were previously, with the difference that only one parrow version got built in the R jobs)

@h-vetinari
Copy link
Contributor Author

Alternatively, I guess an argument could be made that one job per arch (counting cpu/cuda) could be enough, which builds all python versions, and then latest R on top.

xhochy pushed a commit to conda-forge/r-arrow-feedstock that referenced this pull request Dec 7, 2022
* build for arrow 10.0.1

* MNT: Re-rendered with conda-build 3.23.2, conda-smithy 3.22.0, and conda-forge-pinning 2022.12.02.15.22.41

* sync with upstream; be explicit about -std=c++17

* re-add ${R_ARGS}

* MNT: Re-rendered with conda-build 3.23.2, conda-smithy 3.22.0, and conda-forge-pinning 2022.12.04.19.22.35

* sync back changes from apache/arrow#14832

Co-authored-by: conda-forge-webservices[bot] <91080706+conda-forge-webservices[bot]@users.noreply.github.com>
@raulcd
Copy link
Member

raulcd commented Dec 7, 2022

Looking at the two remaining failures

I have manually re-run conda-linux-aarch64-cpu-r41 and it has succeeded

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried reviewing the different commits individually and looks good to me

@kou
Copy link
Member

kou commented Dec 7, 2022

Can we merge this as-is? This fixes our nightly CI.
We can work on some improvements as follow-up tasks.

@kou
Copy link
Member

kou commented Dec 12, 2022

No objection. I'll merge this.

@kou kou merged commit 16d0eb4 into apache:master Dec 12, 2022
@h-vetinari h-vetinari deleted the conda_ci branch December 12, 2022 21:32
@ursabot
Copy link

ursabot commented Dec 14, 2022

Benchmark runs are scheduled for baseline = 3e2a224 and contender = 16d0eb4. 16d0eb4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.27% ⬆️0.2%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 16d0eb4d ec2-t3-xlarge-us-east-2
[Finished] 16d0eb4d test-mac-arm
[Finished] 16d0eb4d ursa-i9-9960x
[Finished] 16d0eb4d ursa-thinkcentre-m75q
[Finished] 3e2a2242 ec2-t3-xlarge-us-east-2
[Finished] 3e2a2242 test-mac-arm
[Finished] 3e2a2242 ursa-i9-9960x
[Finished] 3e2a2242 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

kou pushed a commit that referenced this pull request Apr 11, 2023
)

As well as other changes that happened on the feedstock since #14832
* Closes: #34669

Lead-authored-by: H. Vetinari <h.vetinari@gmx.com>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
apache#34652)

As well as other changes that happened on the feedstock since apache#14832
* Closes: apache#34669

Lead-authored-by: H. Vetinari <h.vetinari@gmx.com>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
apache#34652)

As well as other changes that happened on the feedstock since apache#14832
* Closes: apache#34669

Lead-authored-by: H. Vetinari <h.vetinari@gmx.com>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
apache#34652)

As well as other changes that happened on the feedstock since apache#14832
* Closes: apache#34669

Lead-authored-by: H. Vetinari <h.vetinari@gmx.com>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI][Conda] Nightly CI jobs aren't maintained
7 participants