-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-1815: [Java] Rename MapVector to StructVector #1490
ARROW-1815: [Java] Rename MapVector to StructVector #1490
Conversation
@siddharthteotia this was pretty much straightforward renaming, so hopefully it is not too disruptive to you downstream. Let me know if I can help run Dremio tests if needed. cc @icexelloss |
@BryanCutler Are these the final names for the vectors? I think we were thinking about calling it |
I think at one point we agreed that we would eventually merge the 2 and just have StructVector, but our most recent discussion was just about changing the name, so I kept it at that in order not to be too disruptive. If @siddharthteotia is ok with merging the 2 now, I can do that now or make a followup PR. |
I believe there was some issues with runtime code optimizations downstream in Dremio that would need to be verified before merging the 2. |
Aha I see. Sounds good to me. @jacques-n I think the last discussion was left at Do you think we can proceed with this patch? Or do sth different? |
I think @jacques-n is on vacation this week, but we can wait for @siddharthteotia to advise |
I am fine with the name changes of MapVector to StructVector. However, I would request to keep the NullableStructVector as of now since there are potential impacts on reader/writer I believe. I would like to patiently rebase Dremio on Arrow master -- we are yet to the changes w.r.t removal of non-nullable vectors and renaming of other vectors. Once that is done, we can hopefully remove NullableStructVector too. |
Hey folks, where do we stand on this? @siddharthteotia are we ok with the changes to MINOR type and reader/writer interface? |
It seems like we should be changing from NullableMapVector => StructVector and MapVector => NonNullableStructVector to be consistent with other names, no? Or do we discuss that as a follow along change? |
I made the above name changes to the vector classes, so we now have |
LGTM +1 |
Cool, will merge. Thanks all! |
Thanks @jacques-n and @wesm! |
This renames the MapVector to StructVector and NullableMapVector to NullableStructVector. Related classes have also been renamed as well as APIs making reference to "Map" meaning a struct. The MinorType.Map is also changed to MinorType.STRUCT.