Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-14869: [C++] Add Cflags.private defining <lib>_STATIC to <lib>.pc.in. #14900

Merged
merged 1 commit into from
Dec 9, 2022
Merged

GH-14869: [C++] Add Cflags.private defining <lib>_STATIC to <lib>.pc.in. #14900

merged 1 commit into from
Dec 9, 2022

Conversation

lukester1975
Copy link
Contributor

@lukester1975 lukester1975 commented Dec 9, 2022 •
edited
Loading

@lukester1975
apacheGH-14869: [C++] Add Cflags.private defining <lib>_STATIC to <li…
109a40a 
…b>.pc.in.

Required for Windows usage of static builds via vcpkg & pkgconfig.
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

⚠️ GitHub issue #14869 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

⚠️ GitHub issue #14869 has no components, please add labels for components.

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

⚠️ GitHub issue #14869 has no components, please add labels for components.

kou
kou approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit a7502c9 into apache:master Dec 9, 2022
@jimwang118 jimwang118 mentioned this pull request Mar 29, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

Assignees
No one assigned
Labels
Component: C++ - Gandiva Component: C++ Component: FlightRPC Component: Parquet Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C++] arrow.pc should have -DARROW_STATIC for Windows static builds
2 participants
@lukester1975 @kou