New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-2299: [Go] Import Go arrow implementation from influxdata/arrow #1739
Conversation
Thanks @stuartcarnie! Steps from here:
See http://incubator.apache.org/ip-clearance/arrow-go-library.html for status on the IP Clearance process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small items (copyright headers in Markdown files), but this is very nearly ready to go. I will take a look at the RAT report also to see if we need to add some exclusions. Thanks @stuartcarnie!
go/arrow/README.md
Outdated
@@ -0,0 +1,155 @@ | |||
Arrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this to "Apache Arrow" (or Apache Arrow for Go). This file needs a copyright header, see https://raw.githubusercontent.com/apache/arrow/master/README.md for example
@@ -0,0 +1,23 @@ | |||
# Package cpu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I'm working on fixing the RAT checks (and also the fact that the release audit wasn't run in this CI build -- since it is a part of the C++ build at the moment), and then will merge this |
NOTE: some code generated files and assembler output from the LLVM compiler do not have the headers as they would be stripped each time code generation is rerun. These files are included so that the Go package is go-gettable without any additional build steps.
rat_exclude_files.txt
+1. Merging on green build |
Change-Id: I3a3bdb36607e56726f40b970a664cd1398fa03a5
thanks @stuartcarnie! Would you mind creating an ID on JIRA so I can assign this to you https://issues.apache.org/jira/browse/ARROW-2299? |
Please let me know if you have opinions on https://issues.apache.org/jira/browse/ARROW-2335 |
@wesm done – username is same as GH |
Great, thanks, I added you to the contributor list (so you can assign yourself JIRAs) and assigned this one to you |
**NOTE:** Some code generated files and assembler output from the LLVM compiler do not have the headers as they would be stripped each time code generation is rerun. These files are included so that the Go package is go-gettable without any additional build steps. Author: Stuart Carnie <stuart.carnie@gmail.com> Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#1739 from stuartcarnie/sgc-go-arrow and squashes the following commits: 95b9b42 <Wes McKinney> Add new ci/travis_release_audit.sh script 2320777 <Wes McKinney> Split Apache RAT check into separate script, always run. Update rat_exclude_files.txt f00fb6f <Stuart Carnie> Rename title; add Apache copyright headers to markdown files f31d8ca <Stuart Carnie> Add Apache copyright headers 3e17fe4 <Stuart Carnie> Initial commit, before copyright update
NOTE:
Some code generated files and assembler output from the LLVM compiler do not have the headers as they would be stripped each time code generation is rerun. These files are included so that the Go package is go-gettable without any additional build steps.